Re: [PATCH 1/2] dt-bindings: remoteproc: qcom,shikra-pas: Document Shikra PAS remoteprocs

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The device tree binding example provides two interconnect paths, violating the `maxItems: 1` constraint inherited from `qcom,pas-common.yaml`.
--

commit 6b248da80633195199f478d98724a0590dfdff63
Author: Komal Bajaj <komal.bajaj@oss.qualcomm.com>

dt-bindings: remoteproc: qcom,shikra-pas: Document Shikra PAS remoteprocs

This commit documents the bindings for the CDSP, LPAICP and MPSS PAS on
the Shikra SoC.

> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,shikra-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,shikra-pas.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,shikra-pas.yaml

[ ... ]

> +examples:
> +  - |
> +    #include <dt-bindings/clock/qcom,rpmcc.h>

[ ... ]

> +        clocks = <&rpmcc RPM_SMD_XO_CLK_SRC>;
> +        clock-names = "xo";
> +
> +        interconnects = <&mem_noc MASTER_AMPSS_M0 RPM_ALWAYS_TAG
> +                         &mc_virt SLAVE_EBI_CH0 RPM_ALWAYS_TAG>,
> +                        <&system_noc MASTER_CRYPTO_CORE0 RPM_ALWAYS_TAG
> +                         &mc_virt SLAVE_EBI_CH0 RPM_ALWAYS_TAG>;

Will this cause a validation failure during make dt_binding_check? 

The qcom,pas-common.yaml schema, which is included earlier in this file
via a $ref, restricts the interconnects property to a maximum of 1 item.
However, the example block here provides two interconnect paths.

> +
> +        power-domains = <&rpmpd RPMHPD_CX>;
> +        power-domain-names = "cx";

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260514-shikra-rproc-v1-0-9afdedeee002@oss.qualcomm.com?part=1