Re: [PATCH 2/2] remoteproc: qcom: pas: Add Shikra remoteproc support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Missing `region_assign_idx` and `region_assign_count` for Shikra CDSP and MPSS resources.
--

commit bfe1ee5022ed8cfda954819b500c3d0c3c26c986
Author: Bibek Kumar Patro <bibek.patro@oss.qualcomm.com>

remoteproc: qcom: pas: Add Shikra remoteproc support

This commit adds support for the CDSP, LPAICP, and MPSS Peripheral
Authentication Service on the Qualcomm Shikra SoC.

> diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
> index da27d1d3c9da6..4d43201b9ada7 100644
> --- a/drivers/remoteproc/qcom_q6v5_pas.c
> +++ b/drivers/remoteproc/qcom_q6v5_pas.c
[ ... ]
> +static const struct qcom_pas_data shikra_cdsp_resource = {
> +	.crash_reason_smem = 601,
> +	.firmware_name = "cdsp.mbn",
> +	.pas_id = 18,
> +	.minidump_id = 7,
> +	.auto_boot = false,
> +	.proxy_pd_names = (char *[]){
> +		"cx",
> +		NULL
> +	},
> +	.load_state = "cdsp",
> +	.ssr_name = "cdsp",
> +	.sysmon_name = "cdsp",
> +	.ssctl_id = 0x17,
> +	.smem_host_id = 5,
> +	.region_assign_vmid = QCOM_SCM_VMID_CDSP,
> +};

Are the region_assign_idx and region_assign_count fields intentionally omitted
here? 

Since they default to 0, qcom_pas_assign_memory_region() will return early
when checking if (!pas->region_assign_idx). This bypasses the TrustZone SCM
memory assignment routine entirely, making the explicitly defined
region_assign_vmid configuration ineffective.

Could this lead to an XPU access control violation if the platform requires
these memory regions to be reassigned to the DSP VM to boot?

[ ... ]
> +static const struct qcom_pas_data shikra_mpss_resource = {
> +	.crash_reason_smem = 421,
> +	.firmware_name = "qdsp6sw.mbn",
> +	.pas_id = 4,
> +	.minidump_id = 3,
> +	.auto_boot = false,
> +	.decrypt_shutdown = true,
> +	.proxy_pd_names = (char *[]){
> +		"cx",
> +		NULL
> +	},
> +	.load_state = "modem",
> +	.ssr_name = "mpss",
> +	.sysmon_name = "modem",
> +	.ssctl_id = 0x12,
> +	.region_assign_vmid = QCOM_SCM_VMID_MSS_MSA,
> +};

Similarly, this structure also defines region_assign_vmid but omits the
index and count fields. Will the MPSS resource face the same memory
assignment bypass issue?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260514-shikra-rproc-v1-0-9afdedeee002@oss.qualcomm.com?part=2