From: sashiko-bot@kernel.org
To: "Varadarajan Narayanan" <varadarajan.narayanan@oss.qualcomm.com>
Cc: krzk+dt@kernel.org, conor+dt@kernel.org, robh@kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: qcom: ipq5210: Add QPIC SPI NAND controller support
Date: Thu, 14 May 2026 12:50:25 +0000 [thread overview]
Message-ID: <20260514125025.B73DFC2BCB3@smtp.kernel.org> (raw)
In-Reply-To: <20260514-ipq5210-nand-v1-2-cbdd7492e826@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `&qpic_nand` node in the board device tree (`ipq5210-rdp504.dts`) is missing the `status = "okay";` property.
--
commit 0c64aa0eee90581723a1d1e649a4fc267a75331a
Author: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com>
arm64: dts: qcom: ipq5210: Add QPIC SPI NAND controller support
This commit adds device tree nodes for QPIC SPI NAND flash controller support
on the ipq5210 SoC. It includes hardware ECC capabilities and DMA support
through BAM.
> diff --git a/arch/arm64/boot/dts/qcom/ipq5210-rdp504.dts b/arch/arm64/boot/dts/qcom/ipq5210-rdp504.dts
> index 941f866ecfe95..4813662c2d6c8 100644
> --- a/arch/arm64/boot/dts/qcom/ipq5210-rdp504.dts
> +++ b/arch/arm64/boot/dts/qcom/ipq5210-rdp504.dts
> @@ -20,6 +20,25 @@ chosen {
> };
> };
>
> +&qpic_bam {
> + status = "okay";
> +};
> +
> +&qpic_nand {
> + pinctrl-0 = <&qpic_snand_default_state>;
> + pinctrl-names = "default";
Should this node include a status = "okay"; property?
The qpic_nand SPI controller is defined with status = "disabled"; by default
in the dtsi file (shown below). Without overriding the status here, will the
controller and its attached SPI NAND flash be probed and instantiated by the
kernel?
[ ... ]
> diff --git a/arch/arm64/boot/dts/qcom/ipq5210.dtsi b/arch/arm64/boot/dts/qcom/ipq5210.dtsi
> index 3761eb03ab246..7fd4291caff20 100644
> --- a/arch/arm64/boot/dts/qcom/ipq5210.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq5210.dtsi
[ ... ]
> @@ -204,6 +204,35 @@ sdhc: mmc@7804000 {
[ ... ]
> + qpic_nand: spi@79b0000 {
> + compatible = "qcom,ipq5210-snand", "qcom,ipq9574-snand";
> + reg = <0x0 0x079b0000 0x0 0x10000>;
[ ... ]
> + status = "disabled";
> + };
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260514-ipq5210-nand-v1-0-cbdd7492e826@oss.qualcomm.com?part=2
prev parent reply other threads:[~2026-05-14 12:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-14 6:45 [PATCH 0/2] Enable QPIC-SPI-NAND controller for ipq5210 Varadarajan Narayanan
2026-05-14 6:45 ` [PATCH 1/2] spi: dt-bindings: spi-qpic-snand: Add ipq5210 compatible Varadarajan Narayanan
2026-05-14 6:45 ` [PATCH 2/2] arm64: dts: qcom: ipq5210: Add QPIC SPI NAND controller support Varadarajan Narayanan
2026-05-14 12:50 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260514125025.B73DFC2BCB3@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=varadarajan.narayanan@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox