Re: [PATCH v1 1/3] dt-bindings: display: rockchip: analogix-dp: Expose inherited properties

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Redefining inherited properties as `true` is a redundant schema inheritance anti-pattern that weakens future validation.
--

commit 6cdf876f78b231fc30c12abedc12fb6b25fa8e18
Author: Damon Ding <damon.ding@rock-chips.com>

dt-bindings: display: rockchip: analogix-dp: Expose inherited properties

The commit adds true values to several properties in the Rockchip Analogix
DP binding schema. The commit message states this is necessary to expose
inherited properties to satisfy unevaluatedProperties constraints.

> diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml b/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml
> index d99b23b88cc59..4118b87b8dc53 100644
> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml
> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip,analogix-dp.yaml
> @@ -49,6 +49,13 @@ properties:
>    aux-bus:
>      $ref: /schemas/display/dp-aux-bus.yaml#
>  
> +  reg: true
> +  interrupts: true
> +  phys: true
> +  phy-names: true
> +  force-hpd: true
> +  ports: true
> +

Is it necessary to redefine these inherited properties to satisfy
unevaluatedProperties constraints?

The base schema analogix,dp.yaml already defines these properties. Properties
evaluated by a $ref within an allOf block are automatically annotated as
evaluated, which should satisfy the unevaluatedProperties: false constraint in
the leaf schema.

Could redefining these properties locally as true introduce a validation
regression if the base schema changes in the future?

Setting them to true translates to allowing any value without constraints.
While the allOf intersection currently enforces the base schema's constraints,
if the base schema is later refactored or removes one of these properties,
this leaf schema might silently accept malformed device trees instead of
failing validation.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260514070133.2275069-1-damon.ding@rock-chips.com?part=1