Re: [PATCH v1 2/3] dt-bindings: display: bridge: analogix-dp: Add data-lanes support for endpoint

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The patch silently adds a deprecated top-level `data-lanes` property that is completely irrelevant to the analogix-dp binding.
- [Low] Inconsistent validation constraints for the `data-lanes` arrays.
--

commit f1eb1174d9c0a3dbfb4324c331483cad76c51c68
Author: Damon Ding <damon.ding@rock-chips.com>

dt-bindings: display: bridge: analogix-dp: Add data-lanes support for endpoint

This commit adds data-lanes property support to the port@1 endpoint for
physical lane mapping configuration in the analogix-dp device tree binding.

> diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,dp.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,dp.yaml
> index 62f0521b09245..a82f9b7776c0a 100644
> --- a/Documentation/devicetree/bindings/display/bridge/analogix,dp.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/analogix,dp.yaml
> @@ -36,19 +36,35 @@ properties:
>        Hotplug detect GPIO.
>        Indicates which GPIO should be used for hotplug detection
>  
> +  data-lanes:
> +    $ref: /schemas/types.yaml#/definitions/uint32-array
> +    deprecated: true
> +    minItems: 1
> +    maxItems: 4
> +    items:
> +      maximum: 3

The commit message states that data-lanes support is being added to the
port@1 endpoint, but this adds a top-level data-lanes property marked as
deprecated.

Is this top-level property addition intended?

Looking at the analogix-dp driver history and earlier analogix_dp.txt
bindings, a root-level data-lanes property does not appear to have been
supported previously.

Does this remnant come from another binding that was accidentally copied?
Leaving it here might pollute the schema and allow invalid device trees
to pass validation with just a deprecation warning instead of an error.

[ ... ]
>        port@1:
>          $ref: /schemas/graph.yaml#/properties/port
> -        description:
> -          Port node with one endpoint connected to a dp-connector node.
> +        description: Port node with one endpoint connected to sink device node.
> +        properties:
> +          endpoint:
> +            $ref: /schemas/media/video-interfaces.yaml#
> +            unevaluatedProperties: false
> +            properties:
> +              data-lanes:
> +                minItems: 1
> +                maxItems: 4
> +                items:
> +                  enum: [ 0, 1, 2, 3 ]

This isn't a bug, but the valid items here are restricted using an enum,
whereas the top-level property uses a maximum constraint. 

If the top-level property is removed as suggested above this inconsistency
will naturally be resolved, but it is worth pointing out in case both
properties are kept.

>  
>      required:
>        - port@0

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260514070133.2275069-1-damon.ding@rock-chips.com?part=2