Re: [PATCH 2/3] clk: qcom: ipq5210: Use icc-clk for enabling NoC related clocks

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Unconditional use of `icc_sync_state` causes a build failure when `CONFIG_INTERCONNECT` is disabled.
--

commit 37903a411799e24a2be5123849fd59d7fd96d50a
Author: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com>

clk: qcom: ipq5210: Use icc-clk for enabling NoC related clocks

This commit uses the icc-clk framework to enable NoC related clocks, adding
interconnect provider configurations. It introduces icc_hws mappings and
sets the sync_state callback to icc_sync_state.

> diff --git a/drivers/clk/qcom/gcc-ipq5210.c b/drivers/clk/qcom/gcc-ipq5210.c
> index 3a786a21bdff5..1111da24b512b 100644
> --- a/drivers/clk/qcom/gcc-ipq5210.c
> +++ b/drivers/clk/qcom/gcc-ipq5210.c
[ ... ]
> @@ -2642,6 +2657,7 @@ static struct platform_driver gcc_ipq5210_driver = {
>  	.driver = {
>  		.name   = "qcom,gcc-ipq5210",
>  		.of_match_table = gcc_ipq5210_match_table,
> +		.sync_state = icc_sync_state,

Will this cause a build failure when CONFIG_INTERCONNECT is disabled?

Looking at include/linux/interconnect-provider.h, icc_sync_state is only
declared when CONFIG_INTERCONNECT is enabled, and there appears to be no
empty inline stub provided for the disabled case. 

If this driver is compiled without the interconnect framework (for instance,
during a COMPILE_TEST), does it result in an undeclared identifier error?

>  	},
>  };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260514-icc-ipq5210-v1-0-b5070dfbe460@oss.qualcomm.com?part=2