Re: [PATCH v18 1/3] dt-bindings: pwm: opencores: Drop starfive compatibles and update maintainers

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
- [High] Removing existing StarFive compatible strings breaks DT schema validation for existing device trees.
- [Medium] The commit silently modifies the `reg` space size in the schema example.
- [Low] The `compatible` schema contains an awkward single-item list structure after modification.
--

commit c3152a2a38b5f4d3a25df0696646b840e0d04b60
Author: Hal Feng <hal.feng@starfivetech.com>

dt-bindings: pwm: opencores: Drop starfive compatibles and update maintainers

Each of the StarFive SoCs has 8 OpenCores PTC IP cores that only differ
by their register base address. There is no need for starfive compatibles to
distinguish them, so they are dropped.

> diff --git a/Documentation/devicetree/bindings/pwm/opencores,pwm.yaml b/Documentation/devicetree/bindings/pwm/opencores,pwm.yaml
> index 52a59d245cdb1..834fb17ec595e 100644
> --- a/Documentation/devicetree/bindings/pwm/opencores,pwm.yaml
> +++ b/Documentation/devicetree/bindings/pwm/opencores,pwm.yaml

[ ... ]

> @@ -20,10 +20,6 @@ allOf:
>  properties:
>    compatible:
>      items:
> -      - enum:
> -          - starfive,jh7100-pwm
> -          - starfive,jh7110-pwm
> -          - starfive,jh8100-pwm
>        - const: opencores,pwm-v1

Does removing the legacy compatible strings break dtbs_check for existing
device trees? Older device trees likely still use the two-string format.

Would it be better to use a oneOf construct to allow both the legacy
two-string format and the new single-string format to maintain backward
compatibility?

This isn't a bug, but leaving a single element under items is an anti-pattern
in dt-schema. Since only one string is allowed now, could this be simplified
to just a direct const property instead of an items array?

[ ... ]

> @@ -48,8 +44,8 @@ additionalProperties: false
>  examples:
>    - |
>      pwm@12490000 {
> -        compatible = "starfive,jh7110-pwm", "opencores,pwm-v1";
> -        reg = <0x12490000 0x10000>;
> +        compatible = "opencores,pwm-v1";
> +        reg = <0x12490000 0x10>;

The commit message mentions dropping the starfive compatibles and updating
maintainers, but does not document changing the register space size from
0x10000 to 0x10.

Could the commit message be updated to explicitly explain and justify this
register size change?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260515054723.25024-1-hal.feng@starfivetech.com?part=1