From: sashiko-bot@kernel.org
To: "Varadarajan Narayanan" <varadarajan.narayanan@oss.qualcomm.com>
Cc: conor+dt@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: thermal: tsens: add ipq5210 & ipq9650 compatible
Date: Fri, 15 May 2026 09:45:49 +0000 [thread overview]
Message-ID: <20260515094550.4527CC2BCB0@smtp.kernel.org> (raw)
In-Reply-To: <20260515-tsens-yaml-v1-1-8039c62cc249@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The newly added compatible strings `qcom,ipq5210-tsens` and `qcom,ipq9650-tsens` were omitted from the `allOf` conditional blocks that enforce constraints for 'v2 of TSENS with combined interrupt' variants.
--
commit 57dc4c24572b04937194d0201464e792021ddf2d
Author: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com>
dt-bindings: thermal: tsens: add ipq5210 & ipq9650 compatible
This commit adds the compatible strings for the thermal sensors on the
ipq5210 and ipq9650.
> diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> index 7d34ba00e684f..fd8031f7f6add 100644
> --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> @@ -89,9 +89,11 @@ properties:
>
> - description: v2 of TSENS with combined interrupt
> enum:
> + - qcom,ipq5210-tsens
> - qcom,ipq5332-tsens
> - qcom,ipq5424-tsens
> - qcom,ipq8074-tsens
> + - qcom,ipq9650-tsens
Should these new compatible strings also be added to the allOf conditional
blocks later in the file that enforce constraints for the v2 TSENS variants
with combined interrupts?
If they are omitted from the if-then blocks that match the existing
compatibles, device trees using the new compatible strings might bypass
these rules and allow invalid configurations to silently pass schema
validation.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260515-tsens-yaml-v1-1-8039c62cc249@oss.qualcomm.com?part=1
prev parent reply other threads:[~2026-05-15 9:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 9:40 [PATCH] dt-bindings: thermal: tsens: add ipq5210 & ipq9650 compatible Varadarajan Narayanan
2026-05-15 9:45 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260515094550.4527CC2BCB0@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=varadarajan.narayanan@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox