* [PATCH] dt-bindings: thermal: tsens: add ipq5210 & ipq9650 compatible
@ 2026-05-15 9:40 Varadarajan Narayanan
2026-05-15 9:45 ` sashiko-bot
0 siblings, 1 reply; 2+ messages in thread
From: Varadarajan Narayanan @ 2026-05-15 9:40 UTC (permalink / raw)
To: Amit Kucheria, Thara Gopinath, Rafael J. Wysocki, Daniel Lezcano,
Zhang Rui, Lukasz Luba, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: linux-pm, linux-arm-msm, devicetree, linux-kernel,
Varadarajan Narayanan
Add the compatible for the thermal sensors on the ipq5210 & ipq9650.
Signed-off-by: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com>
---
Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
index 7d34ba00e684..fd8031f7f6ad 100644
--- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
+++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
@@ -89,9 +89,11 @@ properties:
- description: v2 of TSENS with combined interrupt
enum:
+ - qcom,ipq5210-tsens
- qcom,ipq5332-tsens
- qcom,ipq5424-tsens
- qcom,ipq8074-tsens
+ - qcom,ipq9650-tsens
- description: v2 of TSENS with combined interrupt
items:
---
base-commit: e98d21c170b01ddef366f023bbfcf6b31509fa83
change-id: 20260515-tsens-yaml-5f517c948b89
Best regards,
--
Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com>
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] dt-bindings: thermal: tsens: add ipq5210 & ipq9650 compatible
2026-05-15 9:40 [PATCH] dt-bindings: thermal: tsens: add ipq5210 & ipq9650 compatible Varadarajan Narayanan
@ 2026-05-15 9:45 ` sashiko-bot
0 siblings, 0 replies; 2+ messages in thread
From: sashiko-bot @ 2026-05-15 9:45 UTC (permalink / raw)
To: Varadarajan Narayanan; +Cc: conor+dt, robh, krzk+dt, devicetree
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The newly added compatible strings `qcom,ipq5210-tsens` and `qcom,ipq9650-tsens` were omitted from the `allOf` conditional blocks that enforce constraints for 'v2 of TSENS with combined interrupt' variants.
--
commit 57dc4c24572b04937194d0201464e792021ddf2d
Author: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com>
dt-bindings: thermal: tsens: add ipq5210 & ipq9650 compatible
This commit adds the compatible strings for the thermal sensors on the
ipq5210 and ipq9650.
> diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> index 7d34ba00e684f..fd8031f7f6add 100644
> --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> @@ -89,9 +89,11 @@ properties:
>
> - description: v2 of TSENS with combined interrupt
> enum:
> + - qcom,ipq5210-tsens
> - qcom,ipq5332-tsens
> - qcom,ipq5424-tsens
> - qcom,ipq8074-tsens
> + - qcom,ipq9650-tsens
Should these new compatible strings also be added to the allOf conditional
blocks later in the file that enforce constraints for the v2 TSENS variants
with combined interrupts?
If they are omitted from the if-then blocks that match the existing
compatibles, device trees using the new compatible strings might bypass
these rules and allow invalid configurations to silently pass schema
validation.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260515-tsens-yaml-v1-1-8039c62cc249@oss.qualcomm.com?part=1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-15 9:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-15 9:40 [PATCH] dt-bindings: thermal: tsens: add ipq5210 & ipq9650 compatible Varadarajan Narayanan
2026-05-15 9:45 ` sashiko-bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox