Re: [PATCH v10 2/4] riscv: dts: spacemit: k1-orangepi-rv2: add SD card support with UHS modes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [High] The intended 'uhs' pinctrl state will never be applied because the underlying host driver (`sdhci-of-k1.c`) lacks dynamic pinctrl state switching logic.
- [Medium] The pinctrl state name 'uhs' deviates from the established MMC subsystem standard 'state_uhs'.
--

commit d986961bd58045bfd797f79421e91fffcf930dbd
Author: Iker Pedrosa <ikerpedrosam@gmail.com>

riscv: dts: spacemit: k1-orangepi-rv2: add SD card support with UHS modes

This commit adds complete SD card controller support with UHS high-speed
modes for the SpacemiT K1 Orange Pi RV2. It enables the sdhci0 controller
with 4-bit bus width, configures power supplies, and sets up pinctrl states
for voltage-dependent pin configuration.

> diff --git a/arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts b/arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts
> index 3a829e3c9cbcd..74665795b9e88 100644
> --- a/arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts
> +++ b/arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts

[ ... ]

> @@ -309,3 +311,21 @@ hub_3_0: hub@2 {
>  		vdd-supply = <&vcc_5v0>;
>  	};
>  };
> +
> +&sdhci0 {
> +	pinctrl-names = "default", "uhs";

Is this pinctrl state name standard for the MMC subsystem? Other device
tree bindings typically use state_uhs rather than uhs for the alternate
UHS pin state. Using state_uhs would align with the established standard
across the subsystem.

> +	pinctrl-0 = <&mmc1_cfg>;
> +	pinctrl-1 = <&mmc1_uhs_cfg>;

Does the underlying host driver (sdhci-of-k1.c) actually switch to this
alternate pinctrl state during voltage changes?

The generic MMC and SDHCI core frameworks do not automatically switch
pinctrl states when entering 1.8V UHS modes. If the host driver lacks the
explicit pinctrl_lookup_state() or pinctrl_select_state() logic, the
physical IO pins will remain permanently stuck in the default 3.3V hardware
state.

Can operating in high-speed modes with mismatched physical signaling
constraints lead to signal integrity failures or data corruption?

> +	bus-width = <4>;
> +	cd-gpios = <&gpio K1_GPIO(80) GPIO_ACTIVE_LOW>;

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260515-orangepi-sd-card-uhs-v10-0-094af27e310d@gmail.com?part=2