Re: [PATCH v10 3/4] riscv: dts: spacemit: k1-bananapi-f3: add SD card support with UHS modes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Missing driver support for UHS pinctrl state switching in SpacemiT SDHCI driver
--

commit dccbc831846f54656728199aecf02388bd320143
Author: Iker Pedrosa <ikerpedrosam@gmail.com>

riscv: dts: spacemit: k1-bananapi-f3: add SD card support with UHS modes

This commit adds complete SD card controller support with UHS high-speed
modes for the SpacemiT K1 Banana Pi F3. It configures the sdhci0
controller, including regulators for power switching and dual pinctrl
states for voltage-dependent pin configuration.

> diff --git a/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts b/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts
> index e20daa50a152f..72f77e9edd63d 100644
> --- a/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts
> +++ b/arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts
[ ... ]
> @@ -374,3 +376,21 @@ hub_3_0: hub@2 {
>  		reset-gpios = <&gpio K1_GPIO(124) GPIO_ACTIVE_LOW>;
>  	};
>  };
> +
> +&sdhci0 {
> +	pinctrl-names = "default", "uhs";
> +	pinctrl-0 = <&mmc1_cfg>;
> +	pinctrl-1 = <&mmc1_uhs_cfg>;

Does the host controller driver (sdhci-of-k1) support switching to the "uhs"
pinctrl state?

The generic mmc and sdhci core subsystems do not automatically parse or
switch to a "uhs" pinctrl state, unlike standard states like "default" or
"sleep".

> +	bus-width = <4>;
> +	cd-gpios = <&gpio K1_GPIO(80) (GPIO_ACTIVE_LOW | GPIO_PULL_UP)>;
> +	no-mmc;
> +	no-sdio;
> +	disable-wp;
> +	cap-sd-highspeed;
> +	vmmc-supply = <&buck4>;
> +	vqmmc-supply = <&aldo1>;

If the driver does not manually look up and select the "uhs" state when
dropping the vqmmc-supply to 1.8V for UHS modes, will the pads remain
locked to the 3.3V configuration?

Could this mismatch between the pad configuration and the supplied power
cause signal integrity issues or data corruption when operating in sdr25,
sdr50, or sdr104 modes?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260515-orangepi-sd-card-uhs-v10-0-094af27e310d@gmail.com?part=3