Re: [PATCH 3/3] arm64: qcom: dts: qcm6490: Add JPEG encoder DT properties

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The new device tree node violates generic naming conventions and contains properties that will fail DT schema validation.
--

commit b8074fba99ec8410569dbab1538fc6fc7f0597b9
Author: Atanas Filipov <atanas.filipov@oss.qualcomm.com>
arm64: qcom: dts: qcm6490: Add JPEG encoder DT properties

Add the required JPEG encoder definitions to the device tree.

> diff --git a/arch/arm64/boot/dts/qcom/kodiak.dtsi b/arch/arm64/boot/dts/qcom/kodiak.dtsi
> --- a/arch/arm64/boot/dts/qcom/kodiak.dtsi
> +++ b/arch/arm64/boot/dts/qcom/kodiak.dtsi
[ ... ]
> @@ -5305,6 +5305,58 @@ port@4 {
>  			};
>  		};
>  
> +		qcom_jpeg_enc: qcom,jpegenc@ac4e000 {

This isn't a bug, but does this node name violate generic naming
conventions? Devicetree specifications generally require using generic
names such as jpeg-encoder@ac4e000 or video-codec@ac4e000 instead of
vendor-specific names.

> +				cell-index = <0>;

Can this cause a schema validation failure? The cell-index property does
not appear to be defined in the qcom,jpeg-encoder.yaml schema. Since the
schema specifies additionalProperties: false, this undocumented property
will trigger a make dtbs_check validation error.

> +				compatible = "qcom,qcm6490-jenc";
> +
> +				reg =
> +						<0 0xac4e000 0 0x4000>,
> +						<0 0xac40000 0 0x1000>;
> +
> +				reg-names =
> +						"jpeg_regs",
> +						"cpas_regs";

Are these reg-names aligned with the schema constraints? It appears they
use underscores, whereas the schema explicitly constrains these items to
use hyphens (jpeg-regs, cpas-regs). This mismatch will cause schema
validation to fail, even though the driver retrieves them safely by index.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260515-qcom-jpeg-v4l2-v1-0-f38c2e1b3555@oss.qualcomm.com?part=3