Re: [PATCH 1/3] media: dt-bindings: qcom: add JPEG encoder binding

[Krzysztof Kozlowski <krzk@kernel.org>]

On 15/05/2026 13:46, Atanas Filipov wrote:
> Add YAML device tree binding for the Qualcomm JPEG encoder
> hardware. This binding is used by the newly added driver and
> describes all required resources, including clocks, power domains,
> IOMMU mappings and interconnect paths.

You must send your patchset for internal review to avoid such
trivialities and known issues.

A nit, subject: drop second/last, redundant "bindings". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

> 
> Signed-off-by: Atanas Filipov <atanas.filipov@oss.qualcomm.com>
> ---
>  .../bindings/media/qcom,jpeg-encoder.yaml          | 122 +++++++++++++++++++++
>  1 file changed, 122 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/qcom,jpeg-encoder.yaml b/Documentation/devicetree/bindings/media/qcom,jpeg-encoder.yaml
> new file mode 100644
> index 000000000000..fac3e654458d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/qcom,jpeg-encoder.yaml

Use compatible

> @@ -0,0 +1,122 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/qcom,jpeg-encoder.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm JPEG Encoder
> +
> +maintainers:
> +  - Azam Sadiq Pasha Kapatrala Syed <akapatra@quicinc.com>
> +  - Hariram Purushothaman <hariramp@quicinc.com>
> +
> +description: |
> +  Qualcomm JPEG Encoder is the JPEG encode hardware present in Qualcomm SoCs
> +
> +properties:
> +  compatible:
> +    items:

> +      - enum:
> +        - qcom,sc7180-jenc
> +        - qcom,sm8250-jenc
> +        - qcom,sm7325-jenc
> +        - qcom,sc7280-jenc
> +        - qcom,qcm6490-jenc
> +        - qcom,sm8550-jenc

Random order?

Heh, and never actually tested.

> +
> +  reg:
> +    maxItems: 2
> +
> +  reg-names:
> +    items:
> +      - const: jpeg-regs
> +      - const: cpas-regs

Drop regs

> +
> +  interrupts:
> +    maxItems: 1
> +
> +  clocks:
> +    minItems: 6

Drop

> +    maxItems: 6
> +
> +  clock-names:
> +    items:
> +    - const: gcc_hf_axi_clk
> +    - const: gcc_sf_axi_clk
> +    - const: core_ahb_clk
> +    - const: cpas_ahb_clk
> +    - const: camnoc_axi_clk
> +    - const: jpeg_clk

Drop _clk. Instead use some useful names.

> +
> +  power-domains:
> +    maxItems: 1
> +
> +  iommus:
> +    maxItems: 2
> +
> +  interconnects:
> +    maxItems: 4
> +
> +  interconnect-names:
> +    items:
> +      - const: cam_ahb
> +      - const: cam_hf_0_mnoc
> +      - const: cam_sf_0_mnoc
> +      - const: cam_sf_icp_mnoc

Use useful names, drop cam

> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - interrupts
> +  - power-domains
> +  - iommus
> +  - interconnects
> +  - interconnect-names
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    qcom_jpeg_enc: qcom,jpegenc@ac4e000 {
> +        cell-index = <0>;
> +        compatible = "qcom,qcm6490-jenc";
> +        reg =
> +            <0 0xac4e000 0 0x4000>,
> +            <0 0xac40000 0 0x1000>;

What sort of style is that? No, this does not match upstream at all.
Don't send downstream code.

Qualcomm has extensive internal guides and tools helping in upstreaming,
so I do not understand why you bypass all this to send us downstream -
literally - junk code.

Best regards,
Krzysztof