Re: [PATCH 1/2] arm64: dts: qcom: Add Eliza CQS SoM platform

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [High] The `&sdhc_1` node for the eMMC is missing the `bus-width = <8>;` property.
- [Low] The included file `pm7550ba-eliza.dtsi` does not exist in the source tree.
--

commit 6e3e74db281e2d9041b4de6ba9def363654c871e
Author: Abel Vesa <abel.vesa@oss.qualcomm.com>

arm64: dts: qcom: Add Eliza CQS SoM platform

This commit adds the Eliza CQS SoM DTSI so it can be included by the EVK
base board DTS. It describes the regulators and board clocks, and enables
eMMC support alongside the ADSP firmware and remoteproc.

> diff --git a/arch/arm64/boot/dts/qcom/eliza-cqs-som.dtsi b/arch/arm64/boot/dts/qcom/eliza-cqs-som.dtsi
> new file mode 100644
> index 0000000000000..5e0f9c1698f88
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/eliza-cqs-som.dtsi
> @@ -0,0 +1,388 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries.
> + */
> +
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
> +#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
> +
> +#include "eliza.dtsi"
> +#include "pm7550ba-eliza.dtsi"

Are we missing a file in this patch series?

The pm7550ba-eliza.dtsi include does not appear to exist in the repository
or in the submitted patches, which will result in a build failure.

[ ... ]

> +&sdhc_1 {
> +	vmmc-supply = <&vreg_l12b>;
> +	vqmmc-supply = <&vreg_l1d>;
> +	pinctrl-0 = <&sdc1_default>;
> +	pinctrl-1 = <&sdc1_sleep>;
> +	pinctrl-names = "default", "sleep";
> +	mmc-hs400-1_8v;

Does this node require an explicit bus-width property for the eMMC?

The node enables mmc-hs400-1_8v, which strictly requires an 8-bit data bus.
Without setting bus-width = <8>, the MMC core will default to a 1-bit bus.

Could this prevent HS400 mode from functioning and degrade storage
performance?

> +	mmc-hs200-1_8v;
> +	non-removable;
> +	supports-cqe;
> +	no-sdio;
> +	no-sd;
> +
> +	status = "okay";
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260515-eliza-dts-qcs-evk-v1-0-7169d78a33e1@oss.qualcomm.com?part=1