Re: [PATCH 2/2] arm64: dts: qcom: Add Eliza CQS EVK board

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] The device tree will fail to compile due to an unresolved node reference to `&uart13` in `eliza-evk.dtsi`.
- [Low] The new board compatible string `qcom,eliza-cqs-evk` is not documented in the dt-bindings.
--

commit 1762700c0c5b81f76d24db53170888e499078dd4
Author: Abel Vesa <abel.vesa@oss.qualcomm.com>
arm64: dts: qcom: Add Eliza CQS EVK board

This commit adds the common Eliza EVK dtsi and the final Eliza CQS EVK dts
files. It provides the device tree configuration for combining the Eliza SoM
with the common EVK base board.

> diff --git a/arch/arm64/boot/dts/qcom/eliza-cqs-evk.dts b/arch/arm64/boot/dts/qcom/eliza-cqs-evk.dts
> new file mode 100644
> index 0000000000000..fcf7d9232805c
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/eliza-cqs-evk.dts
[ ... ]
> @@ -0,0 +1,20 @@
[ ... ]
> +/ {
> +	model = "Qualcomm Technologies, Inc. Eliza CQS EVK";
> +	compatible = "qcom,eliza-cqs-evk", "qcom,eliza";

Is this new compatible string documented in the dt-bindings?

A search of the Documentation directory suggests qcom,eliza-cqs-evk is
missing from the binding files, which could cause dt_binding_check to fail.

[ ... ]
> diff --git a/arch/arm64/boot/dts/qcom/eliza-evk.dtsi b/arch/arm64/boot/dts/qcom/eliza-evk.dtsi
> new file mode 100644
> index 0000000000000..e47b24f8b8277
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/eliza-evk.dtsi
> @@ -0,0 +1,20 @@
[ ... ]
> +&uart13 {
> +	compatible = "qcom,geni-debug-uart";
> +
> +	status = "okay";
> +};

Will the device tree compiler fail with an unresolved node reference here?

It appears the base SoC file defines the UART as uart14, while this code tries
to reference and modify uart13 which is not defined in the inclusion chain.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260515-eliza-dts-qcs-evk-v1-0-7169d78a33e1@oss.qualcomm.com?part=2