Re: [PATCH 1/6] ARM: dts: imx: add (power|vdd)-supply for related node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The newly added `reg_5v` regulator in `imx53-sk-imx53.dts` incorrectly has `regulator-name = "usb_vbus"`.
--

commit 1eaf7d9176cad41b8d33d56943e5b16020f26bf0
Author: Frank Li <Frank.Li@nxp.com>

ARM: dts: imx: add (power|vdd)-supply for related node

This commit adds required power-supply and vdd-supply properties to fix
CHECK_DTB warnings for several imx devicetrees.

> diff --git a/arch/arm/boot/dts/nxp/imx/imx53-sk-imx53.dts b/arch/arm/boot/dts/nxp/imx/imx53-sk-imx53.dts
> index 1a00d290092ad..c1e065359fd2d 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx53-sk-imx53.dts
> +++ b/arch/arm/boot/dts/nxp/imx/imx53-sk-imx53.dts
> @@ -29,6 +29,13 @@ memory@70000000 {
>  		reg = <0x70000000 0x20000000>;
>  	};
>  
> +	reg_5v: regulator-5v {
> +		compatible = "regulator-fixed";
> +		regulator-name = "usb_vbus";

Is "usb_vbus" the intended name for this regulator?

Since this regulator is used to power the display panel, the name appears
to be a copy-paste error from the reg_usb1_vbus node directly below it.

Defining multiple regulators with the exact same name can cause sysfs
directory collisions and registration warnings in the regulator subsystem.

Would a unique name like "5V" or "panel-5v" be more appropriate here?

> +		regulator-min-microvolt = <5000000>;
> +		regulator-max-microvolt = <5000000>;
> +	};
> +
>  	reg_usb1_vbus: regulator-usb-vbus {
>  		compatible = "regulator-fixed";
>  		regulator-name = "usb_vbus";

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260515-imx25_dts_simple_warning_2-v1-0-b06bff192a05@nxp.com?part=1