Re: [PATCH 5/6] ARM: dts: imx: replace undocumented compatible string edt,edt-ft5x06 with edt,edt-ft5206

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The commit message inaccurately claims that the 'edt,edt-ft5x06' compatible string is not used by the existing driver.
- [Low] Incomplete replacement of the 'edt,edt-ft5x06' compatible string in the i.MX device trees.
--

commit 41200cd2fe9679c5de99c8f7d34c6e5a590d761b
Author: Frank Li <Frank.Li@nxp.com>

ARM: dts: imx: replace undocumented compatible string edt,edt-ft5x06 with edt,edt-ft5206

This commit replaces the undocumented edt,edt-ft5x06 compatible string with
edt,edt-ft5206 across various i.MX device trees to resolve dtbs_check
schema validation warnings.

> ABI impact consideration:
> Not affect Linux kernel ABI because edt,edt-ft5x06 is not used by the
> existing driver. U-Boot does not parse or use edt,edt-ft* touchscreen
> compatibles.

This isn't a bug, but is this explanation of the ABI impact accurate?

The I2C subsystem uses a legacy fallback mechanism where it strips the vendor
prefix from the compatible string to derive the client name, resulting in
edt-ft5x06.

This derived client name successfully matches against the driver's
i2c_device_id table in drivers/input/touchscreen/edt-ft5x06.c, which
explicitly contains an entry for:

	{ .name = "edt-ft5x06", .driver_data = (long)&edt_ft5x06_data },

Because of this, the driver was actively binding to these devices based on
this compatible string. While changing it to the documented edt,edt-ft5206
is functionally correct to cleanly match the of_match_table, does the
rationale provided in the commit message reflect the I2C/OF core matching
semantics?

[ ... ]
> diff --git a/arch/arm/boot/dts/nxp/imx/imx53-m53menlo.dts b/arch/arm/boot/dts/nxp/imx/imx53-m53menlo.dts
> index 2acbc86cabb31..aa1c7e5012c6a 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx53-m53menlo.dts
> +++ b/arch/arm/boot/dts/nxp/imx/imx53-m53menlo.dts
> @@ -248,7 +248,7 @@ &i2c1 {
>  	status = "okay";
>  
>  	touchscreen@38 {
> -		compatible = "edt,edt-ft5x06";
> +		compatible = "edt,edt-ft5206";

Are there still remaining instances of this undocumented compatible string
in the tree?

It appears the exact same string still remains in the tree:

arch/arm/boot/dts/nxp/imx/imx6qdl-nitrogen6_som2.dtsi:
	touchscreen@38 {
		compatible = "edt,edt-ft5x06";
		reg = <0x38>;
		...
	};

Because this occurrence was omitted, will schema validation warnings
persist for any board incorporating this dtsi file?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260515-imx25_dts_simple_warning_2-v1-0-b06bff192a05@nxp.com?part=5