Re: [PATCH v6 03/11] dt-bindings: mfd: add documentation for S2MU005 PMIC

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 961 bytes --]

On Sun, May 17, 2026 at 06:39:37PM +0530, Kaustabh Chakraborty wrote:
>> >> >> +
> >> >> +    properties:
> >> >> +      compatible:
> >> >> +        const: samsung,s2mu005-rgb
> >> >> +
> >> >> +    required:
> >> >> +      - compatible
> >> >> +
> >> >> +    unevaluatedProperties: false
> >> >> +
> >> >> +  reg:
> >> >> +    maxItems: 1
> >> >
> >> > Move this above the child nodes please.
> >> 
> >> But properties are sorted in lex order?
> >
> > Typically the binding is sorted in the same order as properties go in
> > nodes. Common stuff like reg/clocks/interrupts therefore send up above
> > child nodes.
> 
> So, do I change this? For one, I don't see the same being followed in
> other schemas of samsung in the same dir (not that I'm trying to pose it
> as an argument against your suggestion), and this was reviewed by
> Krzysztof and is adderssed in v7.

If Krzysztof doesn't care, then I won't ask you to change it.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]