[PATCH 1/1] riscv: dts: spacemit: enable QSPI for OrangePi RV2

[PATCH 1/1] riscv: dts: spacemit: enable QSPI for OrangePi RV2

[Chukun Pan]

Enable the QSPI controller and the XM25QU128C SPI NOR flash on the
OrangePi RV2 board. Add a flash partition layout from vendor UBoot.

Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
---
 .../boot/dts/spacemit/k1-orangepi-rv2.dts     | 45 +++++++++++++++++++
 1 file changed, 45 insertions(+)

diff --git a/arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts b/arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts
index c95ca38e3d4a..3081065cec0e 100644
--- a/arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts
+++ b/arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts
@@ -288,6 +288,51 @@ &pcie2 {
 	status = "okay";
 };
 
+&qspi {
+	pinctrl-names = "default";
+	pinctrl-0 = <&qspi_cfg>;
+	status = "okay";
+
+	flash@0 {
+		compatible = "jedec,spi-nor";
+		reg = <0>;
+		spi-max-frequency = <26500000>;
+		spi-rx-bus-width = <4>;
+		spi-tx-bus-width = <4>;
+		vcc-supply = <&buck3_1v8>;
+
+		partitions {
+			compatible = "fixed-partitions";
+			#address-cells = <1>;
+			#size-cells = <1>;
+
+			bootinfo@0 {
+				reg = <0x00000 0x010000>;
+			};
+
+			private@10000 {
+				reg = <0x10000 0x010000>;
+			};
+
+			fsbl@20000 {
+				reg = <0x20000 0x040000>;
+			};
+
+			env@60000 {
+				reg = <0x60000 0x010000>;
+			};
+
+			opensbi@70000 {
+				reg = <0x70000 0x030000>;
+			};
+
+			uboot@a00000 {
+				reg = <0xa0000 0x760000>;
+			};
+		};
+	};
+};
+
 &uart0 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&uart0_2_cfg>;
-- 
2.34.1

Re: [PATCH 1/1] riscv: dts: spacemit: enable QSPI for OrangePi RV2

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Mismatch between node unit-address and 'reg' property for the uboot partition.
--

commit ac1df28fb4536a816c17f35ce989f0804943afb5
Author: Chukun Pan <amadeus@jmu.edu.cn>

riscv: dts: spacemit: enable QSPI for OrangePi RV2

This commit enables the QSPI controller and the XM25QU128C SPI NOR flash
on the OrangePi RV2 board. It also adds a flash partition layout derived
from the vendor U-Boot.

> diff --git a/arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts b/arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts
> --- a/arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts
> +++ b/arch/riscv/boot/dts/spacemit/k1-orangepi-rv2.dts
[ ... ]
> +			opensbi@70000 {
> +				reg = <0x70000 0x030000>;
> +			};
> +
> +			uboot@a00000 {
> +				reg = <0xa0000 0x760000>;

Is there a mismatch between the unit-address and the reg property here?

The node name uses a00000 (implying an address of 0xa00000), but the reg
property specifies a start address of 0xa0000. 

This difference will usually trigger a unit_address_vs_reg warning when
compiling the device tree with dtc. Should the node name or the reg address
be updated so they match exactly?

> +			};
> +		};
> +	};
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260516080030.1736836-1-amadeus@jmu.edu.cn?part=1

Re: [PATCH 1/1] riscv: dts: spacemit: enable QSPI for OrangePi RV2

[Yixun Lan]

Hi Chukun,

On 16:00 Sat 16 May     , Chukun Pan wrote:
> Enable the QSPI controller and the XM25QU128C SPI NOR flash on the
> OrangePi RV2 board. Add a flash partition layout from vendor UBoot.
> 
> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
LGTM

Reviewed-by: Yixun Lan <dlan@kernel.org>

> ---
>  .../boot/dts/spacemit/k1-orangepi-rv2.dts     | 45 +++++++++++++++++++
>  1 file changed, 45 insertions(+)

-- 
Yixun Lan (dlan)

Re: [PATCH 1/1] riscv: dts: spacemit: enable QSPI for OrangePi RV2

[Yixun Lan]

On Sat, 16 May 2026 16:00:30 +0800, Chukun Pan wrote:
> Enable the QSPI controller and the XM25QU128C SPI NOR flash on the
> OrangePi RV2 board. Add a flash partition layout from vendor UBoot.

Applied, thanks!

[1/1] riscv: dts: spacemit: enable QSPI for OrangePi RV2
      https://github.com/spacemit-com/linux/commit/dd5c5b54c3be5a1422f05a23370779235043434d

Best regards,
-- 
Yixun Lan <dlan@kernel.org>

Re: [PATCH 1/1] riscv: dts: spacemit: enable QSPI for OrangePi RV2

[Chukun Pan]

Hi,

> Applied, thanks!

Wow, you're so fast!
The robot report has one typo:

> +			uboot@a00000 {
> +				reg = <0xa0000 0x760000>;
> +			};

This should be:
```
			uboot@a0000 {
```

Could you fix it? Or I can send the v2 patch.

Thanks,
Chukun

Re: [PATCH 1/1] riscv: dts: spacemit: enable QSPI for OrangePi RV2

[Yixun Lan]

Hi Chukun,

On 15:00 Sun 17 May     , Chukun Pan wrote:
> Hi,
> 
> > Applied, thanks!
> 
> Wow, you're so fast!
> The robot report has one typo:
> 
> > +			uboot@a00000 {
> > +				reg = <0xa0000 0x760000>;
> > +			};
> 
> This should be:
> ```
> 			uboot@a0000 {
> ```
> 
> Could you fix it? Or I can send the v2 patch.
> 
Ok, I will fix it

-- 
Yixun Lan (dlan)

Re: [PATCH 1/1] riscv: dts: spacemit: enable QSPI for OrangePi RV2

[Vincent Legoll]

Hi Yixun Lan, Chukun Pan,

I tried spacemit-com/for-next (e2518e8cb1dde64af2d1bb246639bb7ef7523f7a) 
on opi-rv2
which includes this patch.

but cannot see anything relevant to SPI in dmesg, whereas I see [Q]SPI 
in u-boot output, but there it is listed as:
[   0.887] SF: Detected XM25QH128A with page size 256 Bytes, erase size 
64 KiB, total 16 MiB
Which is not the same you tested (XM25QU128C).

Am I missing something ?
How can I know this patch is working properly ?
What should I test ?
What should I report ?
Is this test useful ?

Thanks

Re: [PATCH 1/1] riscv: dts: spacemit: enable QSPI for OrangePi RV2

[Chukun Pan]

Hi,

> but cannot see anything relevant to SPI in dmesg, whereas I see [Q]SPI 
> in u-boot output, but there it is listed as:
> [   0.887] SF: Detected XM25QH128A with page size 256 Bytes, erase size 
> 64 KiB, total 16 MiB
> Which is not the same you tested (XM25QU128C).

Please do not trust the flash name printed by vendor UBoot.
XM25QU128C is 0x204118, while XM25QH128A is 0x207018.

~ # cat /sys/kernel/debug/spi-nor/spi0.0/params 
name            spi-nor-generic
id              20 41 18 20 41 18
size            16.0 MiB

You can also check the silkscreen of the SPI NOR flash. By
the way, the IO voltages of these two flashes are different.

> How can I know this patch is working properly ?

[    1.116594] 6 fixed-partitions partitions found on MTD device d420c000.spi
[    1.116609] Creating 6 MTD partitions on "d420c000.spi":
[    1.116615] 0x000000000000-0x000000010000 : "bootinfo"
[    1.119280] 0x000000010000-0x000000020000 : "private"
[    1.120718] 0x000000020000-0x000000060000 : "fsbl"
[    1.122064] 0x000000060000-0x000000070000 : "env"
[    1.126373] 0x000000070000-0x0000000a0000 : "opensbi"
[    1.127679] 0x0000000a0000-0x000000800000 : "uboot"

These partitions can be tested using the mtd command.
Or simply view the contents of these partitions:
~ # hexdump -C /dev/mtd0

Thanks,
Chukun