Re: [PATCH v3 1/4] dt-bindings: arm: qcom: document the Ayaneo Pocket DS

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The compatible string 'ayaneo,pocketds' violates Devicetree naming conventions by omitting a hyphen between words.
--

commit afa187f3006436f1b9cb60821ba5f70e1c3ff499
Author: Alexandre Hamamdjian <azkali.limited@gmail.com>

dt-bindings: arm: qcom: document the Ayaneo Pocket DS

This commit adds device tree binding documentation for the Ayaneo Pocket DS
gaming console, based on the Qualcomm QCS8550 platform.

> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index 2741c07e9f416..f130a6b092b95 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
[ ... ]
> @@ -1107,6 +1107,12 @@ properties:
>            - const: qcom,qcs8550
>            - const: qcom,sm8550
>  
> +      - items:
> +          - enum:
> +              - ayaneo,pocketds

This isn't a bug, but there is a missing hyphen in the compatible string.

Should this be ayaneo,pocket-ds instead? The commit message refers to the
device as the Ayaneo Pocket DS, and the sibling entry for the Ayaneo Pocket S2
uses the hyphenated form ayaneo,pocket-s2.

A check of subsequent patches in the series confirms the string remains
uncorrected.

> +          - const: qcom,qcs8550
> +          - const: qcom,sm8550
> +

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260517-pocketds-v3-0-d5910c801756@gmail.com?part=1