Re: [PATCH v3 2/4] arm64: dts: qcom: sm8550: add labels for thermal zones

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Incomplete implementation: missing labels for almost all CPU thermal zones despite commit message claims.
--

commit 32e1020122d8ab932064f6929e94b9d9f74c8a75
Author: Alexandre Hamamdjian <azkali.limited@gmail.com>

arm64: dts: qcom: sm8550: add labels for thermal zones

This commit adds labels to the cpuss, cpu, and gpuss thermal zones in
the sm8550 device tree. This is intended to allow board files to override
trip points and cooling maps using labels instead of full node paths.

> diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
> index 912525e9bca6f..a9c678fc9cb2e 100644
> --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
[ ... ]
> @@ -6028,7 +6028,7 @@ cpu6_bottom_crit: cpu-critical {
>  			};
>  		};
>  
> -		cpu7-top-thermal {
> +		cpu7_top_thermal: cpu7-top-thermal {
>  			thermal-sensors = <&tsens0 13>;
>  
>  			trips {

The commit message states that labels are added for the cpu thermal zones,
but it looks like only cpu7-top-thermal was updated here.

Were the other CPU thermal zones in this file, such as cpu0-thermal,
cpu1-thermal, cpu3-bottom-thermal, and cpu7-bottom-thermal intentionally
left without labels, or did they get missed during the update?

If they are left out, it seems board files will not be able to extend those
remaining zones using the label override syntax.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260517-pocketds-v3-0-d5910c801756@gmail.com?part=2