Re: [PATCH 2/6] dt-bindings: usb: add Qualcomm PMI8998 Type-C controller

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `qcom,spmi-pmic.yaml` parent schema unconditionally enforces the old `qcom,pmic-typec.yaml` on all `typec@` nodes, which will cause `dtbs_check` validation failures for the newly introduced `qcom,pmi8998-typec` hardware node.
--

commit 1c9db8c5249c49002058f3167b19c898d414957d
Author: taygoth <taygoth@gmail.com>
dt-bindings: usb: add Qualcomm PMI8998 Type-C controller

This commit adds a new devicetree binding for the Qualcomm PMI8998 USB
Type-C role-switch controller. It describes a hardware block distinct from
the TCPM-based qcom,pmic-typec controllers, using a single consolidated
interrupt instead of granular per-event IRQs.

> diff --git a/Documentation/devicetree/bindings/usb/qcom,pmi8998-typec.yaml b/Documentation/devicetree/bindings/usb/qcom,pmi8998-typec.yaml
> new file mode 100644
> index 0000000000000..f2814f5ce3de7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/qcom,pmi8998-typec.yaml
[ ... ]
> +examples:
> +  - |
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +
> +    pmic {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        typec@1300 {
> +            compatible = "qcom,pmi8998-typec";

Will this node cause dtbs_check validation failures when instantiated
under the PMIC?

In Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml, the
patternProperties rule for ^typec@[0-9a-f]+$ has a hardcoded reference
to /schemas/usb/qcom,pmic-typec.yaml#.

Because this new qcom,pmi8998-typec schema defines only 1 interrupt instead
of the 8 to 16 required by the older binding, it will fail validation
against the parent PMIC schema.

Should the parent qcom,spmi-pmic.yaml schema be updated alongside this
change to permit this new hardware block?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1779127507.git.taygoth@gmail.com?part=2