Re: [PATCH 4/6] arm64: dts: qcom: pmi8998: add USB Type-C and VBUS regulator nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] Devicetree schema validation failure for VBUS regulator node due to incorrect name and missing properties.
- [Medium] Devicetree schema validation failure for Type-C node due to schema routing conflict and missing required subnode.
--

commit d114c820eb701d590cfd5b3e5e83a32def5c8605
Author: taygoth <taygoth@gmail.com>

arm64: dts: qcom: pmi8998: add USB Type-C and VBUS regulator nodes

This commit adds disabled nodes for the PMI8998 PMIC USB Type-C detection
block and the USB OTG VBUS boost converter. The VBUS regulator falls back
to the pm8150b-vbus-reg compatible due to identical register layouts.

> --- a/arch/arm64/boot/dts/qcom/pmi8998.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pmi8998.dtsi
> @@ -29,6 +29,25 @@ pmi8998_charger: charger@1000 {
>  			status = "disabled";
>  		};
>  
> +		pmi8998_vbus: vbus-reg@1100 {

Will this node name cause a devicetree schema validation failure during
dtbs_check?

It looks like Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml
enforces the node name pattern ^usb-vbus-regulator@[0-9a-f]+$ and has
additionalProperties: false.

> +			compatible = "qcom,pmi8998-vbus-reg",
> +				     "qcom,pm8150b-vbus-reg";
> +			reg = <0x1100>;

Are we missing the regulator-min-microamp and regulator-max-microamp
properties here? 

The qcom,usb-vbus-regulator.yaml schema strictly requires them, which might
trigger warnings for all boards including pmi8998.dtsi even if the status is
disabled.

> +			status = "disabled";
> +		};
> +
> +		pmi8998_typec: typec@1300 {

Does naming this node typec@1300 create a schema routing conflict?

The pattern ^typec@[0-9a-f]+$ in qcom,spmi-pmic.yaml hardcodes a reference
to /schemas/usb/qcom,pmic-typec.yaml#. Since qcom,pmi8998-typec has its own
binding and isn't permitted in qcom,pmic-typec.yaml, dtbs_check might
evaluate it against the wrong schema and reject the compatible string.

> +			compatible = "qcom,pmi8998-typec";
> +			reg = <0x1300>;
> +
> +			interrupts = <0x2 0x13 0x7 IRQ_TYPE_EDGE_BOTH>;
> +			interrupt-names = "type-c-change";
> +
> +			vdd-vbus-supply = <&pmi8998_vbus>;

Does this node also need the connector subnode? It appears to be explicitly
listed as required in qcom,pmi8998-typec.yaml.

> +
> +			status = "disabled";
> +		};

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1779127507.git.taygoth@gmail.com?part=4