Re: [PATCH net v2 1/5] dt-bindings: ethernet: eswin: add optional TXD and RXD delay register offsets

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1932 bytes --]

On Tue, May 19, 2026 at 02:23:33AM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] Missing `minItems: 4` constraint makes the newly added optional cells mandatory, breaking schema backward compatibility.
> --
> 
> commit 2992483df88af2823c275fc86187f7e38acbee5c
> Author: Zhi Li <lizhi2@eswincomputing.com>
> 
> dt-bindings: ethernet: eswin: add optional TXD and RXD delay register offsets
> 
> This commit documents two optional cells in the eswin,hsp-sp-csr property
> for the TXD and RXD delay control register offsets.
> 
> > diff --git a/Documentation/devicetree/bindings/net/eswin,eic7700-eth.yaml b/Documentation/devicetree/bindings/net/eswin,eic7700-eth.yaml
> > --- a/Documentation/devicetree/bindings/net/eswin,eic7700-eth.yaml
> > +++ b/Documentation/devicetree/bindings/net/eswin,eic7700-eth.yaml
> 
> [ ... ]
> 
> > @@ -82,6 +91,8 @@ properties:
> >            - description: Offset of AXI clock controller Low-Power request
> >                           register
> >            - description: Offset of register controlling TX/RX clock delay
> > +          - description: Optional offset of register controlling TXD delay
> > +          - description: Optional offset of register controlling RXD delay
> 
> Will this make the two new offsets strictly required instead of optional?
> 
> In dt-schema, when an items list defines a tuple, minItems implicitly
> defaults to the total number of items in that list. By increasing the list
> from 4 to 6 items without adding a minItems: 4 constraint to the inner items
> list, won't validation now strictly require exactly 6 items?
> 
> Could this cause dt_binding_check to fail for existing device trees that
> correctly specify only the original 4 elements?

Looks like a valid complaint to me.
pw-bot: changes-requested

Cheers,
Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]