From: sashiko-bot@kernel.org
To: "Hangxiang Ma" <hangxiang.ma@oss.qualcomm.com>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org
Subject: Re: [PATCH 1/3] arm64: dts: qcom: sm8750: Add camss node
Date: Tue, 19 May 2026 07:29:51 +0000 [thread overview]
Message-ID: <20260519072952.55F9AC2BCB3@smtp.kernel.org> (raw)
In-Reply-To: <20260519-pakala-camera-v1-1-b6d897864916@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch introduces the `qcom,sm8750-camss` compatible string without a corresponding dt-bindings schema update.
--
commit bdba0f08239906fe3e720590f288dff966c590cb
Author: Hangxiang Ma <hangxiang.ma@oss.qualcomm.com>
arm64: dts: qcom: sm8750: Add camss node
This commit adds the camera subsystem node for the SM8750 SoC.
> diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qcom/sm8750.dtsi
> --- a/arch/arm64/boot/dts/qcom/sm8750.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi
[ ... ]
> + camss: isp@ad27000 {
> + compatible = "qcom,sm8750-camss";
This isn't a bug, but is there a corresponding dt-bindings schema update
for this new compatible string included in this series?
Adding a new compatible string to a device tree node without updating the
YAML binding schemas in Documentation/devicetree/bindings/ will cause
schema validation to fail during dtbs_check.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260519-pakala-camera-v1-0-b6d897864916@oss.qualcomm.com?part=1
next prev parent reply other threads:[~2026-05-19 7:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-19 7:17 [PATCH 0/3] Add CCI and CAMSS support for SM8750 Hangxiang Ma
2026-05-19 7:17 ` [PATCH 1/3] arm64: dts: qcom: sm8750: Add camss node Hangxiang Ma
2026-05-19 7:29 ` sashiko-bot [this message]
2026-05-19 7:17 ` [PATCH 2/3] arm64: dts: qcom: sm8750: Add CCI definitions Hangxiang Ma
2026-05-19 7:17 ` [PATCH 3/3] arm64: dts: qcom: sm8750: Add camera MCLK pinctrl Hangxiang Ma
2026-05-19 7:52 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260519072952.55F9AC2BCB3@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hangxiang.ma@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox