Re: [PATCH 3/3] arm64: dts: qcom: sm8750: Add camera MCLK pinctrl

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Incorrect pinctrl function names `cam_asc_mclk2` and `cam_asc_mclk4` used for camera MCLK on pins 91 and 93.
--

commit e6d2727b68fe7979bbe116baa48b879e9333356a
Author: Hangxiang Ma <hangxiang.ma@oss.qualcomm.com>

arm64: dts: qcom: sm8750: Add camera MCLK pinctrl
    
This commit defines pinctrl definitions to enable camera master clocks on
SM8750.

> diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qcom/sm8750.dtsi
> index e45f0d33714c5..f1e34d2860beb 100644
> --- a/arch/arm64/boot/dts/qcom/sm8750.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi

[ ... ]

> @@ -3850,6 +3850,62 @@ tlmm: pinctrl@f100000 {

[ ... ]

> +			cam2_default: cam2-default-state {
> +				pins = "gpio91";
> +				function = "cam_asc_mclk2";

Is this function name correct? The pinctrl subsystem relies on strict
string matching to map devicetree functions to driver functions.

According to the SM8750 pinctrl driver and bindings, the function for
this pin appears to be defined as cam_aon_mclk2. Using a non-existent name
will cause devicetree schema validation to fail and result in runtime errors,
preventing the camera clock from being configured.

> +				drive-strength = <2>;
> +				bias-disable;
> +			};

[ ... ]

> +			cam4_default: cam4-default-state {
> +				pins = "gpio93";
> +				function = "cam_asc_mclk4";

Does this function also need to be updated to cam_aon_mclk4?

> +				drive-strength = <2>;
> +				bias-disable;
> +			};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260519-pakala-camera-v1-0-b6d897864916@oss.qualcomm.com?part=3