Re: [PATCH 1/3] dt-bindings: power: limits: Describe Qualcomm SPEL hardware

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The unit-address in the example node name does not match the first address in the `reg` property.
--

commit f3971a9e10b2466608195c2613f6957464048b20
Author: Manaf Meethalavalappu Pallikunhi <manaf.pallikunhi@oss.qualcomm.com>

dt-bindings: power: limits: Describe Qualcomm SPEL hardware

This commit adds a DeviceTree binding to describe the SoC Power and Electrical
Limits (SPEL) block on Qualcomm SoCs.

> diff --git a/Documentation/devicetree/bindings/power/limits/qcom,spel.yaml b/Documentation/devicetree/bindings/power/limits/qcom,spel.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/limits/qcom,spel.yaml

[ ... ]

> +examples:
> +  - |
> +    power-controller@ef3b000 {
> +        compatible = "qcom,spel";
> +        reg = <0x0ef3e000 0x1000>,

This isn't a bug, but does the unit-address in the example node name match
the first address in the reg property? 

It looks like the node is named power-controller@ef3b000, but the first
address in the reg property is 0x0ef3e000. This mismatch will likely trigger
a dtc warning during dt_binding_check.

> +              <0x0ef3d000 0x1000>,
> +              <0x0ef3b000 0x1000>;
> +        reg-names = "nodes",
> +                    "constraints",
> +                    "config";
> +    };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260519-qcom_spel_driver_upstream-v1-0-75356d1b7f94@oss.qualcomm.com?part=1