From: sashiko-bot@kernel.org
To: "Manaf Meethalavalappu Pallikunhi" <manaf.pallikunhi@oss.qualcomm.com>
Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 3/3] arm64: dts: qcom: glymur: Enable SPEL powercap driver
Date: Tue, 19 May 2026 11:25:20 +0000 [thread overview]
Message-ID: <20260519112521.0A747C2BCB3@smtp.kernel.org> (raw)
In-Reply-To: <20260519-qcom_spel_driver_upstream-v1-3-75356d1b7f94@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The unit-address of the `power-controller` node (`@ef3b000`) does not match the first address specified in the `reg` property (`0x0ef3e000`).
--
commit 2d003127cde30ba8cb78978e9f333e066d842620
Author: Manaf Meethalavalappu Pallikunhi <manaf.pallikunhi@oss.qualcomm.com>
arm64: dts: qcom: glymur: Enable SPEL powercap driver
This commit adds the Qualcomm SoC Power and Electrical Limits (SPEL) node
to the glymur device tree. This enables hardware-based power monitoring and
limiting capabilities for various power domains.
> diff --git a/arch/arm64/boot/dts/qcom/glymur.dtsi b/arch/arm64/boot/dts/qcom/glymur.dtsi
> index 72c7dc6e4f098..c0ba8740ae413 100644
> --- a/arch/arm64/boot/dts/qcom/glymur.dtsi
> +++ b/arch/arm64/boot/dts/qcom/glymur.dtsi
[ ... ]
> + power-controller@ef3b000 {
> + compatible = "qcom,spel";
> + reg = <0x0 0x0ef3e000 0x0 0x1000>,
This isn't a bug, but the unit-address in the node name (@ef3b000) does not
match the first address specified in the reg property (0x0ef3e000).
Should the node name be updated to power-controller@ef3e000 to match the
first reg entry and avoid compiler warnings?
> + <0x0 0x0ef3d000 0x0 0x1000>,
> + <0x0 0x0ef3b000 0x0 0x1000>;
> + reg-names = "nodes",
> + "constraints",
> + "config";
> + };
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260519-qcom_spel_driver_upstream-v1-0-75356d1b7f94@oss.qualcomm.com?part=3
prev parent reply other threads:[~2026-05-19 11:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-19 10:49 [PATCH 0/3] Add Qualcomm SPEL powercap driver Manaf Meethalavalappu Pallikunhi
2026-05-19 10:49 ` [PATCH 1/3] dt-bindings: power: limits: Describe Qualcomm SPEL hardware Manaf Meethalavalappu Pallikunhi
2026-05-19 10:57 ` sashiko-bot
2026-05-19 17:40 ` Rob Herring (Arm)
2026-05-19 10:49 ` [PATCH 2/3] powercap: qcom: Add SPEL powercap driver Manaf Meethalavalappu Pallikunhi
2026-05-19 11:20 ` sashiko-bot
2026-05-19 10:49 ` [PATCH 3/3] arm64: dts: qcom: glymur: Enable " Manaf Meethalavalappu Pallikunhi
2026-05-19 11:25 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260519112521.0A747C2BCB3@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=manaf.pallikunhi@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox