Re: [PATCH 1/6] dt-bindings: usb: qcom,pmic-typec: deprecate device-specific VBUS

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] Removing `vdd-vbus-supply` from the `required` list without enforcing a replacement constraint allows device trees to omit a VBUS supply entirely.
- [Low] The YAML example still uses the deprecated `vdd-vbus-supply` property instead of demonstrating the newly recommended `vbus-supply` inside the `connector` node.
--

commit 41dafb66aa6b39b2228e9fd24e01754d63882c2d
Author: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Subject: dt-bindings: usb: qcom,pmic-typec: deprecate device-specific VBUS

Qualcomm PMIC Type-C devices historically provided their own way of
specifying the vbus regulator via the vdd-vbus-supply node. This commit
deprecates the vdd-vbus-supply property in favour of the standard
connector's vbus-supply property.

> diff --git a/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml b/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml
> index 6d3fa2bc9ceec..7a68423fb97ce 100644
> --- a/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml
> +++ b/Documentation/devicetree/bindings/usb/qcom,pmic-typec.yaml
> @@ -79,7 +79,8 @@ properties:
>        - const: fr-swap
>  
>    vdd-vbus-supply:
> -    description: VBUS power supply.
> +    deprecated: true
> +    description: use connector/vbus-supply instead.

This isn't a regression, but could the example at the bottom of the file
be updated to reflect this change?

The example still uses the deprecated vdd-vbus-supply property rather than
demonstrating the newly recommended vbus-supply property inside the
connector node.

[ ... ]

> @@ -94,7 +95,6 @@ required:
>    - reg
>    - interrupts
>    - interrupt-names
> -  - vdd-vbus-supply

Does this allow incomplete device trees to pass validation?

By removing vdd-vbus-supply from the required list without adding a
replacement constraint, the schema can now silently validate device trees
that lack both the legacy vdd-vbus-supply and the new connector/vbus-supply.

Should an anyOf block be added to enforce that at least one of the
vbus supply properties is present?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260519-fix-tcpm-vbus-v1-0-14754695282d@oss.qualcomm.com?part=1