Re: [PATCH 4/6] arm64: dts: qcom: pm7250b: move vdd-vbus-supply to connector nodes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Critical] Removing `vdd-vbus-supply` from `pm7250b.dtsi` breaks VBUS functionality for older kernels booting with this updated device tree.
--

commit 248f42632176b717a6099ac7dd20eb6355d2d9ed
Author: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>

arm64: dts: qcom: pm7250b: move vdd-vbus-supply to connector nodes

This commit removes the vdd-vbus-supply property from the pm7250b_typec
node and instead specifies vbus-supply on the connector node.

> diff --git a/arch/arm64/boot/dts/qcom/pm7250b.dtsi b/arch/arm64/boot/dts/qcom/pm7250b.dtsi
> index 0761e6b5fd8d1..43cab07126c5c 100644
> --- a/arch/arm64/boot/dts/qcom/pm7250b.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pm7250b.dtsi
> @@ -86,7 +86,6 @@ pm7250b_typec: typec@1500 {
>  					  "msg-tx-discarded",
>  					  "msg-rx-discarded",
>  					  "fr-swap";
> -			vdd-vbus-supply = <&pm7250b_vbus>;

Will removing vdd-vbus-supply cause a regression for older kernels booting
with this updated device tree?

Older versions of the qcom_pmic_typec driver do not parse the vbus-supply
property from the connector child node, and instead call
devm_regulator_get(dev, "vdd-vbus") on the parent PMIC Type-C node.

Because NORMAL_GET is used, the regulator core will fall back to returning a
dummy regulator instead of failing. Will the driver silently enable the
dummy regulator, preventing the real VBUS from being enabled and breaking
USB Type-C power on existing boards like the Fairphone 4?

Should the deprecated vdd-vbus-supply property be retained for a transition
period to maintain backwards compatibility?

>  			status = "disabled";
>  		};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260519-fix-tcpm-vbus-v1-0-14754695282d@oss.qualcomm.com?part=4