Re: [PATCH v3 1/2] dt-bindings: iio: dac: Add AD5529R

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The `patternProperties` regex for child channel nodes incorrectly expects decimal unit addresses instead of hexadecimal, causing valid device tree nodes to fail validation.
--

commit 137584b720b9b8966a6cb2fb8c6b4d98d2bf3d55
Author: Janani Sunil <janani.sunil@analog.com>

dt-bindings: iio: dac: Add AD5529R

This commit adds devicetree bindings for the AD5529R 16-channel 12/16-bit
high voltage DAC. It defines properties for programmable output ranges, SPI
communication, and GPIO pins.

> diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5529r.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5529r.yaml
> new file mode 100644
> index 0000000000000..eb66f6ca063dc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5529r.yaml
[ ... ]
> +patternProperties:
> +  "^channel@([0-9]|1[0-5])$":
[Severity: Medium]
Does this pattern incorrectly expect decimal unit addresses instead of
hexadecimal?

According to the Devicetree specification, node unit addresses must be
written in lower-case hexadecimal without a "0x" prefix. Since the AD5529R
has 16 channels, valid reg values of 0 through 15 correspond to unit
addresses 0 through f (e.g., channel@a).

This regex expects decimal strings 10 through 15 for values 10-15. If a
user correctly writes channel@a for channel 10, it will fail to match this
regex.

Because the schema enforces unevaluatedProperties: false at the top level,
these nodes will be rejected by validation tools. Alternatively, if the
user incorrectly names the node channel@10 to pass schema validation, dtc
will produce a unit address format mismatch warning since "10" is evaluated
as hex 16.

Could the regex be updated to match single-character hexadecimal values
(e.g., "^channel@[0-9a-f]$")?

> +    type: object
> +    description: Child nodes for individual channel configuration

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260519-ad5529r-driver-v3-0-267c0731aa68@analog.com?part=1