Devicetree
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jisheng Zhang <jszhang@kernel.org>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
	 Frank Li <Frank.Li@nxp.com>, Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	 Philipp Zabel <p.zabel@pengutronix.de>,
	linux-i3c@lists.infradead.org, devicetree@vger.kernel.org,
	 linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/4] i3c: dw: Remove core reset "_rst" suffix
Date: Wed, 20 May 2026 09:13:58 +0200	[thread overview]
Message-ID: <20260520-scrupulous-notorious-ibis-ab6cbc@quoll> (raw)
In-Reply-To: <20260519055105.13079-2-jszhang@kernel.org>

On Tue, May 19, 2026 at 01:51:02PM +0800, Jisheng Zhang wrote:
> It's redundant. This suffix has been in the code from day1, fortunately
> there's no such dt property usage in all dw i3c users after grepping all
> dts files, so we can remove it.

Hm, how could you grep all 3rd party / out of tree users of this?

> 
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
> ---
>  drivers/i3c/master/dw-i3c-master.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c
> index 655693a2187e..c4a848cc978a 100644
> --- a/drivers/i3c/master/dw-i3c-master.c
> +++ b/drivers/i3c/master/dw-i3c-master.c
> @@ -1587,7 +1587,7 @@ int dw_i3c_common_probe(struct dw_i3c_master *master,
>  		return PTR_ERR(master->pclk);
>  
>  	master->core_rst = devm_reset_control_get_optional_exclusive_deasserted(&pdev->dev,
> -										"core_rst");
> +										"core");

ABI impact for something released since 2018. Cleanup of name is not
really worth affecting users. core_rst is not the best name but it is
not incorrect, either.

Best regards,
Krzysztof


  reply	other threads:[~2026-05-20  7:14 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-19  5:51 [PATCH v3 0/4] i3c: dw: Add apb reset support Jisheng Zhang
2026-05-19  5:51 ` [PATCH v3 1/4] i3c: dw: Remove core reset "_rst" suffix Jisheng Zhang
2026-05-20  7:13   ` Krzysztof Kozlowski [this message]
2026-05-20 11:43     ` Jisheng Zhang
2026-05-24 18:41       ` Krzysztof Kozlowski
2026-05-19  5:51 ` [PATCH v3 2/4] dt-bindings: i3c: dw: Describe core reset Jisheng Zhang
2026-05-20  7:14   ` Krzysztof Kozlowski
2026-05-20 11:50     ` Jisheng Zhang
2026-05-19  5:51 ` [PATCH v3 3/4] dt-bindings: i3c: dw: Add apb reset Jisheng Zhang
2026-05-19  6:48   ` sashiko-bot
2026-05-19  5:51 ` [PATCH v3 4/4] i3c: dw: Add apb reset support Jisheng Zhang
2026-05-19  6:58   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260520-scrupulous-notorious-ibis-ab6cbc@quoll \
    --to=krzk@kernel.org \
    --cc=Frank.Li@nxp.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jszhang@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-i3c@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox