Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Himanshu Bhavani" <himanshu.bhavani@siliconsignals.io>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: media: i2c: Add imx576 sensor
Date: Wed, 20 May 2026 12:08:16 +0000	[thread overview]
Message-ID: <20260520120817.29DCF1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260520115641.11729-2-himanshu.bhavani@siliconsignals.io>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Critical] The voltage specifications for DOVDD (I/O) and DVDD (Digital Core) are swapped in the property descriptions.
--

commit 9b15ba2292de0fba24f7e296cd6c14ec7bd1a56b
Author: Hardevsinh Palaniya <hardevsinh.palaniya@siliconsignals.io>

dt-bindings: media: i2c: Add imx576 sensor

This commit adds device tree bindings for the Sony IMX576 image sensor.
It defines the hardware interface properties including MIPI CSI-2 endpoints,
regulators, and clock requirements.

> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx576.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx576.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx576.yaml
[ ... ]
> +  avdd-supply:
> +    description: Analog Domain Power Supply (2.8v)
> +
> +  dovdd-supply:
> +    description: I/O Domain Power Supply (1.05v)
> +
> +  dvdd-supply:
> +    description: Digital Domain Power Supply (1.8v)

[Severity: Critical]
Are the voltage specifications for the DOVDD and DVDD supplies swapped in
these descriptions?

For Sony IMX sensors, DOVDD typically operates at 1.8V and DVDD operates at
~1.05V.

Following this documentation caused a subsequent commit ("arm64: dts: qcom:
sm7225-fairphone-fp4: Add Sony IMX576 front camera support") to map a 1.8V
regulator to dvdd-supply and a 1.05V regulator to dovdd-supply.

Can applying 1.8V to the 1.05V digital core domain cause permanent hardware
damage to the sensor?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260520115641.11729-1-himanshu.bhavani@siliconsignals.io?part=1

  reply	other threads:[~2026-05-20 12:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-20 11:56 [PATCH 0/3] media: i2c: Add imx576 camera sensor driver Himanshu Bhavani
2026-05-20 11:56 ` [PATCH 1/3] dt-bindings: media: i2c: Add imx576 sensor Himanshu Bhavani
2026-05-20 12:08   ` sashiko-bot [this message]
2026-05-20 12:09   ` Luca Weiss
2026-05-20 11:56 ` [PATCH 2/3] media: i2c: add imx576 image sensor driver Himanshu Bhavani
2026-05-20 12:33   ` Laurent Pinchart
2026-05-20 12:43   ` sashiko-bot
2026-05-20 11:56 ` [PATCH 3/3] arm64: dts: qcom: sm7225-fairphone-fp4: Add Sony IMX576 front camera support Himanshu Bhavani
2026-05-20 12:14   ` Luca Weiss
2026-05-20 13:38   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260520120817.29DCF1F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=himanshu.bhavani@siliconsignals.io \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox