Re: [PATCH 3/3] arm64: dts: qcom: sm7225-fairphone-fp4: Add Sony IMX576 front camera support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 4 potential issue(s) to consider:
- [High] The DOVDD (Digital I/O) and DVDD (Digital Core) power supplies are swapped, applying 1.8V to the 1.05V digital core domain and risking irreversible hardware damage.
- [Medium] The custom `vdd-csiphy3-0p9-supply` and `vdd-csiphy3-1p25-supply` properties are not supported by the upstream CAMSS driver.
- [Low] The patch references an undefined `&camss` label, which will cause a Device Tree Compiler (DTC) build failure.
- [Low] The `port@3` node is missing the required `reg = <3>;` property.
--

commit e96fe4e80a1f906989411986c814165ecd67c277
Author: Hardevsinh Palaniya <hardevsinh.palaniya@siliconsignals.io>

arm64: dts: qcom: sm7225-fairphone-fp4: Add Sony IMX576 front camera support

This commit adds device tree support for the Sony IMX576 front camera
sensor. It connects the sensor to the CAMSS subsystem via CSIPHY3.

> diff --git a/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts b/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts
> --- a/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts
> +++ b/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts

[ ... ]

> @@ -547,6 +548,24 @@ vreg_bob: bob {
>  	};
>  };
>  
> +&camss {

[Severity: Low]
Is the camss label defined anywhere in the tree? It doesn't appear to be
present in sm7225-fairphone-fp4.dts or its included dtsi files, which
would cause a build error.

> +
> +	vdd-csiphy3-0p9-supply = <&vreg_l18a>;
> +	vdd-csiphy3-1p25-supply = <&vreg_l22a>;

[Severity: Medium]
Does the upstream CAMSS driver support these custom supply names? The
upstream driver maps regulator supplies using hardcoded string arrays instead
of custom supply properties like vdd-csiphy3-0p9-supply.

> +
> +	status = "okay";
> +
> +	ports {
> +		port@3 {

[Severity: Low]
Should this node include a reg = <3>; property to match the unit address?

> +			csiphy3_ep: endpoint {
> +				data-lanes = <0 1 2 3>;
> +				bus-type = <MEDIA_BUS_TYPE_CSI2_DPHY>;
> +				remote-endpoint = <&camera_imx576_ep>;
> +			};
> +		};
> +	};
> +};

[ ... ]

> @@ -582,6 +601,34 @@ &cci1 {
>  
>  &cci1_i2c0 {
>  	/* Front cam (Sony IMX576) @ 0x10 */
> +	camera@10 {
> +		compatible = "sony,imx576";
> +		reg = <0x10>;
> +
> +		avdd-supply = <&vreg_l3p>;
> +		dovdd-supply = <&vreg_32m_cam_dvdd_1p05>;
> +		dvdd-supply = <&vreg_l6p>;

[Severity: High]
Can this damage the hardware? The 1.05V regulator (vreg_32m_cam_dvdd_1p05)
is assigned to dovdd-supply, while the 1.8V regulator (vreg_l6p) is assigned
to dvdd-supply.

Should these be swapped to avoid applying 1.8V to the 1.05V digital core
domain?

> +
> +		clocks = <&camcc CAMCC_MCLK1_CLK>;

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260520115641.11729-1-himanshu.bhavani@siliconsignals.io?part=3