Re: [PATCH v11] riscv: dts: spacemit: k1-musepi-pro: add SD card support with UHS modes

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Inverted SD card detect polarity in `cd-gpios` property.
--

commit b8da2f3ea83cbd0820dd4246075e26e687bac678
Author: Trevor Gamblin <tgamblin@baylibre.com>

riscv: dts: spacemit: k1-musepi-pro: add SD card support with UHS modes

This commit updates the Muse Pi Pro device tree to add SD card support,
enabling the sdhci0 controller with a 4-bit bus, UHS-I modes, and voltage
switching.

Link: https://lore.kernel.org/linux-riscv/20260316-orangepi-sd-card-uhs-v3-0-aefd3b7832df@gmail.com/T/#

> diff --git a/arch/riscv/boot/dts/spacemit/k1-musepi-pro.dts b/arch/riscv/boot/dts/spacemit/k1-musepi-pro.dts
> --- a/arch/riscv/boot/dts/spacemit/k1-musepi-pro.dts
> +++ b/arch/riscv/boot/dts/spacemit/k1-musepi-pro.dts
[ ... ]
> +&sdhci0 {
> +	pinctrl-names = "default", "uhs";
> +	pinctrl-0 = <&mmc1_cfg>;
> +	pinctrl-1 = <&mmc1_uhs_cfg>;
> +	bus-width = <4>;
> +	cd-gpios = <&gpio K1_GPIO(80) (GPIO_ACTIVE_HIGH | GPIO_PULL_UP)>;

[Severity: High]
Should this cd-gpios property use GPIO_ACTIVE_LOW?

With an internal pull-up enabled, the physical card-detect switch usually
connects the pin to ground when a card is inserted, driving the signal low.
Using GPIO_ACTIVE_HIGH might cause the MMC subsystem to assume a card is
inserted when the slot is empty, and report a removal event when a card is
actually inserted.

The commit message mentions matching the OrangePi RV2 configuration, which
would typically use GPIO_ACTIVE_LOW for a pulled-up card detect signal.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260520130624.1763487-1-a.heider@gmail.com?part=1