Re: [PATCH V8 2/2] arm64: dts: qcom: glymur-crd: add Audio sound card node

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [High] The `audio-routing` property uses lowercase strings, which will fail to match the dynamically created ALSA ASoC DAPM widgets, leaving the speakers disconnected.
- [High] The right woofer is incorrectly routed to the SPK2 output instead of SPK1, which breaks the audio stream routing.
--

commit 4086f61ae4a41fcc2e29b8dbcc7878956275252b
Author: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>

arm64: dts: qcom: glymur-crd: add Audio sound card node

This commit adds the sound card node for the Glymur-crd board. It defines
the audio routing for speakers and adds device nodes for the WSA884x
smart speakers and DMIC microphones.

> diff --git a/arch/arm64/boot/dts/qcom/glymur-crd.dtsi b/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
> index e784b538f42e1..4c00d09f766c2 100644
> --- a/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
> +++ b/arch/arm64/boot/dts/qcom/glymur-crd.dtsi
> @@ -68,6 +68,54 @@ switch-lid {
>  		};
>  	};
>  
> +	sound {
> +		compatible = "qcom,glymur-sndcard";
> +		model = "GLYMUR-CRD";
> +		audio-routing = "wooferleft in", "wsa wsa_spk1 out",
> +				"tweeterleft in", "wsa wsa_spk2 out",
> +				"wooferright in", "wsa2 wsa_spk2 out",

[Severity: High]
ALSA DAPM string matching for audio routing is exact and case-sensitive.
The widgets are created with names derived from sound-name-prefix (e.g.,
WooferLeft) and the widget type suffix (e.g., IN), making the expected name
"WooferLeft IN".

Similarly, the WSA macros create widgets with uppercase names like
"WSA WSA_SPK1 OUT".

Does using lowercase names here cause snd_soc_dapm_add_route() to silently
fail to find the matching widgets, leaving the speakers disconnected?

[Severity: High]
The right_woofer node defines qcom,port-mapping = <1 2 3 7 12 14>, which
corresponds to the first SoundWire stream on the WSA2 macro. This first
stream connects to the WSA2 WSA_SPK1 OUT DAPM widget.

Could routing wooferright to wsa2 wsa_spk2 out connect the woofer to the
tweeter's stream instead, breaking the crossover and preventing the right
woofer from receiving its proper audio stream?

[ ... ]

> +&swr3 {
> +	status = "okay";
> +
> +	/* WSA8845, Right Woofer */
> +	right_woofer: speaker@0,0 {
> +		compatible = "sdw20217020400";
> +		reg = <0 0>;
> +		reset-gpios = <&lpass_tlmm 13 GPIO_ACTIVE_LOW>;
> +		#sound-dai-cells = <0>;
> +		sound-name-prefix = "WooferRight";
> +		vdd-1p8-supply = <&vreg_l15b_e0_1p8>;
> +		vdd-io-supply = <&vreg_l18b_e0_1p2>;
> +		qcom,port-mapping = <1 2 3 7 12 14>;
> +	};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260520141828.2724689-1-sibi.sankar@oss.qualcomm.com?part=2