Re: [PATCH v5 1/2] dt-bindings: display: panel: document the Renesas R63419 based dual-DSI video mode Display Panels

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The schema incorrectly uses `additionalProperties: false` instead of `unevaluatedProperties: false` when inheriting from a common schema.
--

commit 06ab207971a6f54327d9bb05b5e8355cbba81b0c
Author: Neil Armstrong <neil.armstrong@linaro.org>

dt-bindings: display: panel: document the Renesas R63419 based dual-DSI video mode Display Panels

This commit adds a new device tree binding document for the Renesas
R63419 generic DDIC. The DDIC is used to control dual-DSI LCD panels,
such as those found in Ayaneo gaming handheld devices.

> diff --git a/Documentation/devicetree/bindings/display/panel/renesas,r63419.yaml b/Documentation/devicetree/bindings/display/panel/renesas,r63419.yaml
> new file mode 100644
> index 0000000000000..adfdd2c300a35
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/renesas,r63419.yaml
[ ... ]
> +allOf:
> +  - $ref: panel-common-dual.yaml#
> +
> +properties:
> +  compatible:
> +    items:
> +      - enum:
> +          - ayaneo,wt0600-2k
> +          - ayaneo,wt0630-2k
> +      - const: renesas,r63419
[ ... ]
> +  backlight: true
> +  reset-gpios: true
> +  rotation: true
> +  ports: true
> +
> +required:
> +  - compatible
> +  - reg
[ ... ]
> +  - reset-gpios
> +  - ports
> +
> +additionalProperties: false

[Severity: Low]
Since this schema inherits from panel-common-dual.yaml in the allOf block
above, should this be unevaluatedProperties: false instead?

In JSON schema, additionalProperties: false only considers the properties
explicitly listed in the local properties block. This means any standard
panel properties (like width-mm, height-mm, or enable-gpios) not explicitly
listed here will be incorrectly rejected during validation.

Using unevaluatedProperties: false would allow properties defined in the
inherited schemas. It would also eliminate the need to redundantly define
properties like backlight or ports in the local properties block.

> +
> +examples:
> +  - |
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260521-topic-sm8650-ayaneo-pocket-s2-r63419-v5-0-dd5700299390@linaro.org?part=1