From: sashiko-bot@kernel.org
To: "Akash Sukhavasi" <akash.sukhavasi@gmail.com>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org
Subject: Re: [PATCH] dt-bindings: serial: rs485: remove deprecated .txt binding stub
Date: Thu, 21 May 2026 15:13:04 +0000 [thread overview]
Message-ID: <20260521151305.186201F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260521150748.4816-1-akash.sukhavasi@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Deleting rs485.txt without updating references to it leaves broken documentation links in the kernel tree.
--
commit 40946518dfeaa6ec990f95ec2dc5dbc4c289791f
Author: Akash Sukhavasi <akash.sukhavasi@gmail.com>
dt-bindings: serial: rs485: remove deprecated .txt binding stub
This commit removes the deprecated plain-text binding stub for rs485,
which was superseded by the YAML schema in an earlier commit. The file
now only contained a redirect notice.
> diff --git a/Documentation/devicetree/bindings/serial/rs485.txt b/Documentation/devicetree/bindings/serial/rs485.txt
> deleted file mode 100644
> index a7fe93efc4a50..0000000000000
> --- a/Documentation/devicetree/bindings/serial/rs485.txt
> +++ /dev/null
> @@ -1 +0,0 @@
> -See rs485.yaml
[Severity: Low]
Does this removal leave dangling documentation links in the tree?
There appear to be references to rs485.txt in drivers/tty/serial/serial_core.c
in the kernel-doc for uart_get_rs485_mode() and in
Documentation/driver-api/serial/serial-rs485.rst in the References section.
Should these references be updated to point to rs485.yaml to avoid broken
documentation links?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260521150748.4816-1-akash.sukhavasi@gmail.com?part=1
next prev parent reply other threads:[~2026-05-21 15:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-21 15:07 [PATCH] dt-bindings: serial: rs485: remove deprecated .txt binding stub Akash Sukhavasi
2026-05-21 15:13 ` sashiko-bot [this message]
2026-05-21 15:28 ` Akash Sukhavasi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260521151305.186201F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=akash.sukhavasi@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox