Devicetree
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: serial: rs485: remove deprecated .txt binding stub
@ 2026-05-21 15:07 Akash Sukhavasi
  2026-05-21 15:13 ` sashiko-bot
  0 siblings, 1 reply; 3+ messages in thread
From: Akash Sukhavasi @ 2026-05-21 15:07 UTC (permalink / raw)
  To: krzk+dt
  Cc: Greg Kroah-Hartman, Jiri Slaby, Rob Herring, Conor Dooley,
	linux-kernel, linux-serial, devicetree

The plain-text binding file was superseded by the YAML schema in
commit d50f974c4f7f ("dt-bindings: serial: Convert rs485 bindings
to json-schema"). The file now contains only a redirect notice.
Remove it.

Signed-off-by: Akash Sukhavasi <akash.sukhavasi@gmail.com>
---
 Documentation/devicetree/bindings/serial/rs485.txt | 1 -
 1 file changed, 1 deletion(-)
 delete mode 100644 Documentation/devicetree/bindings/serial/rs485.txt

diff --git a/Documentation/devicetree/bindings/serial/rs485.txt b/Documentation/devicetree/bindings/serial/rs485.txt
deleted file mode 100644
index a7fe93efc..000000000
--- a/Documentation/devicetree/bindings/serial/rs485.txt
+++ /dev/null
@@ -1 +0,0 @@
-See rs485.yaml
-- 
2.54.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: serial: rs485: remove deprecated .txt binding stub
  2026-05-21 15:07 [PATCH] dt-bindings: serial: rs485: remove deprecated .txt binding stub Akash Sukhavasi
@ 2026-05-21 15:13 ` sashiko-bot
  2026-05-21 15:28   ` Akash Sukhavasi
  0 siblings, 1 reply; 3+ messages in thread
From: sashiko-bot @ 2026-05-21 15:13 UTC (permalink / raw)
  To: Akash Sukhavasi; +Cc: conor+dt, devicetree, robh

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Deleting rs485.txt without updating references to it leaves broken documentation links in the kernel tree.
--

commit 40946518dfeaa6ec990f95ec2dc5dbc4c289791f
Author: Akash Sukhavasi <akash.sukhavasi@gmail.com>

dt-bindings: serial: rs485: remove deprecated .txt binding stub

This commit removes the deprecated plain-text binding stub for rs485,
which was superseded by the YAML schema in an earlier commit. The file
now only contained a redirect notice.

> diff --git a/Documentation/devicetree/bindings/serial/rs485.txt b/Documentation/devicetree/bindings/serial/rs485.txt
> deleted file mode 100644
> index a7fe93efc4a50..0000000000000
> --- a/Documentation/devicetree/bindings/serial/rs485.txt
> +++ /dev/null
> @@ -1 +0,0 @@
> -See rs485.yaml

[Severity: Low]
Does this removal leave dangling documentation links in the tree?

There appear to be references to rs485.txt in drivers/tty/serial/serial_core.c
in the kernel-doc for uart_get_rs485_mode() and in
Documentation/driver-api/serial/serial-rs485.rst in the References section.

Should these references be updated to point to rs485.yaml to avoid broken
documentation links?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260521150748.4816-1-akash.sukhavasi@gmail.com?part=1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] dt-bindings: serial: rs485: remove deprecated .txt binding stub
  2026-05-21 15:13 ` sashiko-bot
@ 2026-05-21 15:28   ` Akash Sukhavasi
  0 siblings, 0 replies; 3+ messages in thread
From: Akash Sukhavasi @ 2026-05-21 15:28 UTC (permalink / raw)
  To: sashiko-bot; +Cc: akash.sukhavasi, conor+dt, devicetree, robh, sashiko-reviews

Thanks for catching them. Had my regex incorrect.
Will send a v2 with the references updated.

Thanks,
Akash

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-05-21 15:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-21 15:07 [PATCH] dt-bindings: serial: rs485: remove deprecated .txt binding stub Akash Sukhavasi
2026-05-21 15:13 ` sashiko-bot
2026-05-21 15:28   ` Akash Sukhavasi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox