Re: [PATCH v2 1/1] dt-bindings: trivial-devices: add fsl,mc1323

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The commit message incorrectly cites a CHECK_DTBS warning for a TV encoder ('fsl,imx53-tve') instead of the ZigBee transceiver ('fsl,mc1323') that the patch actually adds.
- [Low] A complex ZigBee radio transceiver is incorrectly classified as a trivial device, masking an incomplete device tree node.
--

commit 2100488cb966e136f1c1fefe29da8444b4dcd893
Author: Frank Li <Frank.Li@nxp.com>
dt-bindings: trivial-devices: add fsl,mc1323

This commit adds the Freescale MC1323 2.4 GHz IEEE 802.15.4/ZigBee 
transceiver to the trivial-devices bindings list to resolve dtbs_check 
warnings on the i.MX53 SMD board.

> Add freescale 2.4 GHz IEEE® 802.15.4/ZigBee mc1323 to fix the below
> CHECK_DTBS warnings.
>   arch/arm/boot/dts/nxp/imx/imx53-smd.dtb: /soc/bus@60000000/tve@63ff0000: failed to match any schema with compatible: ['fsl,imx53-tve']

[Severity: Medium]
Is the CHECK_DTBS warning cited here correct for this patch?

The warning mentions a TV encoder ('fsl,imx53-tve') at a different node,
but this patch adds the ZigBee transceiver ('fsl,mc1323'). 

It looks like the wrong error log might have been pasted into the commit
message.

> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index 23fd4513933a4..28b059c858dd1 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -127,6 +127,8 @@ properties:
>            - domintech,dmard09
>              # DMARD10: 3-axis Accelerometer
>            - domintech,dmard10
> +            # Freescale 2.4 GHz IEEE® 802.15.4/ZigBee
> +          - fsl,mc1323

[Severity: Low]
Should a complex ZigBee radio transceiver be classified as a trivial device?

The trivial-devices.yaml schema is intended for simple devices requiring
only compatible, reg, and optionally interrupts properties. As an IEEE
802.15.4 MAC/PHY transceiver, wouldn't the MC1323 inherently require other
hardware resources like clocks or regulators?

Adding it to the trivial list seems to bypass proper DT validation and
could mask an incomplete device tree node.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260521195233.1532852-1-Frank.Li@oss.nxp.com?part=1