* [PATCH v2 1/1] dt-bindings: trivial-devices: add fsl,mc1323
@ 2026-05-21 19:52 Frank.Li
2026-05-21 20:02 ` sashiko-bot
2026-05-21 20:25 ` Frank Li
0 siblings, 2 replies; 3+ messages in thread
From: Frank.Li @ 2026-05-21 19:52 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Guenter Roeck,
Frank Li, Wensheng Wang, Cosmo Chou, Brian Chiang, Eddie James,
Nuno Sá, Antoni Pokusinski, Dixit Parmar,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Cc: imx
From: Frank Li <Frank.Li@nxp.com>
Add freescale 2.4 GHz IEEE® 802.15.4/ZigBee mc1323 to fix the below
CHECK_DTBS warnings.
arch/arm/boot/dts/nxp/imx/imx53-smd.dtb: /soc/bus@60000000/tve@63ff0000: failed to match any schema with compatible: ['fsl,imx53-tve']
Since the i.MX53 platform is more than 20 years old, it is difficult to
find detailed information about how the MC1323 was used on the i.MX53 SMD
board, as the functionality depended on firmware.
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
change in v2
- add descript about reason in commit message
---
Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
index 46a4dca50c485..6ff96e10d0785 100644
--- a/Documentation/devicetree/bindings/trivial-devices.yaml
+++ b/Documentation/devicetree/bindings/trivial-devices.yaml
@@ -127,6 +127,8 @@ properties:
- domintech,dmard09
# DMARD10: 3-axis Accelerometer
- domintech,dmard10
+ # Freescale 2.4 GHz IEEE® 802.15.4/ZigBee
+ - fsl,mc1323
# MMA7660FC: 3-Axis Orientation/Motion Detection Sensor
- fsl,mma7660
# MMA8450Q: Xtrinsic Low-power, 3-axis Xtrinsic Accelerometer
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/1] dt-bindings: trivial-devices: add fsl,mc1323
2026-05-21 19:52 [PATCH v2 1/1] dt-bindings: trivial-devices: add fsl,mc1323 Frank.Li
@ 2026-05-21 20:02 ` sashiko-bot
2026-05-21 20:25 ` Frank Li
1 sibling, 0 replies; 3+ messages in thread
From: sashiko-bot @ 2026-05-21 20:02 UTC (permalink / raw)
To: Frank.Li; +Cc: devicetree, Frank.Li, conor+dt, robh, imx
Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The commit message incorrectly cites a CHECK_DTBS warning for a TV encoder ('fsl,imx53-tve') instead of the ZigBee transceiver ('fsl,mc1323') that the patch actually adds.
- [Low] A complex ZigBee radio transceiver is incorrectly classified as a trivial device, masking an incomplete device tree node.
--
commit 2100488cb966e136f1c1fefe29da8444b4dcd893
Author: Frank Li <Frank.Li@nxp.com>
dt-bindings: trivial-devices: add fsl,mc1323
This commit adds the Freescale MC1323 2.4 GHz IEEE 802.15.4/ZigBee
transceiver to the trivial-devices bindings list to resolve dtbs_check
warnings on the i.MX53 SMD board.
> Add freescale 2.4 GHz IEEE® 802.15.4/ZigBee mc1323 to fix the below
> CHECK_DTBS warnings.
> arch/arm/boot/dts/nxp/imx/imx53-smd.dtb: /soc/bus@60000000/tve@63ff0000: failed to match any schema with compatible: ['fsl,imx53-tve']
[Severity: Medium]
Is the CHECK_DTBS warning cited here correct for this patch?
The warning mentions a TV encoder ('fsl,imx53-tve') at a different node,
but this patch adds the ZigBee transceiver ('fsl,mc1323').
It looks like the wrong error log might have been pasted into the commit
message.
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index 23fd4513933a4..28b059c858dd1 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -127,6 +127,8 @@ properties:
> - domintech,dmard09
> # DMARD10: 3-axis Accelerometer
> - domintech,dmard10
> + # Freescale 2.4 GHz IEEE® 802.15.4/ZigBee
> + - fsl,mc1323
[Severity: Low]
Should a complex ZigBee radio transceiver be classified as a trivial device?
The trivial-devices.yaml schema is intended for simple devices requiring
only compatible, reg, and optionally interrupts properties. As an IEEE
802.15.4 MAC/PHY transceiver, wouldn't the MC1323 inherently require other
hardware resources like clocks or regulators?
Adding it to the trivial list seems to bypass proper DT validation and
could mask an incomplete device tree node.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260521195233.1532852-1-Frank.Li@oss.nxp.com?part=1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/1] dt-bindings: trivial-devices: add fsl,mc1323
2026-05-21 19:52 [PATCH v2 1/1] dt-bindings: trivial-devices: add fsl,mc1323 Frank.Li
2026-05-21 20:02 ` sashiko-bot
@ 2026-05-21 20:25 ` Frank Li
1 sibling, 0 replies; 3+ messages in thread
From: Frank Li @ 2026-05-21 20:25 UTC (permalink / raw)
To: Frank.Li
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Guenter Roeck,
Wensheng Wang, Cosmo Chou, Brian Chiang, Eddie James,
Nuno Sá, Antoni Pokusinski, Dixit Parmar,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list, imx
On Thu, May 21, 2026 at 03:52:31PM -0400, Frank.Li@oss.nxp.com wrote:
> From: Frank Li <Frank.Li@nxp.com>
>
> Add freescale 2.4 GHz IEEE® 802.15.4/ZigBee mc1323 to fix the below
> CHECK_DTBS warnings.
> arch/arm/boot/dts/nxp/imx/imx53-smd.dtb: /soc/bus@60000000/tve@63ff0000: failed to match any schema with compatible: ['fsl,imx53-tve']
Sorry, paste wrong error log here, should be
arch/arm/boot/dts/nxp/imx/imx53-smd.dtb: /soc/bus@50000000/spba-bus@50000000/spi@50010000/mc1323@0: failed to match any schema with compatible: ['fsl,mc1323']
Frank
>
> Since the i.MX53 platform is more than 20 years old, it is difficult to
> find detailed information about how the MC1323 was used on the i.MX53 SMD
> board, as the functionality depended on firmware.
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> change in v2
> - add descript about reason in commit message
> ---
> Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index 46a4dca50c485..6ff96e10d0785 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -127,6 +127,8 @@ properties:
> - domintech,dmard09
> # DMARD10: 3-axis Accelerometer
> - domintech,dmard10
> + # Freescale 2.4 GHz IEEE® 802.15.4/ZigBee
> + - fsl,mc1323
> # MMA7660FC: 3-Axis Orientation/Motion Detection Sensor
> - fsl,mma7660
> # MMA8450Q: Xtrinsic Low-power, 3-axis Xtrinsic Accelerometer
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-05-21 20:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-21 19:52 [PATCH v2 1/1] dt-bindings: trivial-devices: add fsl,mc1323 Frank.Li
2026-05-21 20:02 ` sashiko-bot
2026-05-21 20:25 ` Frank Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox