Re: [PATCH v3 1/1] dt-bindings: trivial-devices: add fsl,mc1323

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The complex 802.15.4/ZigBee transceiver (Freescale MC1323) is being incorrectly added to trivial-devices.yaml.
--

commit b0a89da340a37ac000b2095bf76877af3c762c6f
Author: Frank Li <Frank.Li@nxp.com>

dt-bindings: trivial-devices: add fsl,mc1323

This commit adds the Freescale MC1323 2.4 GHz IEEE 802.15.4/ZigBee
transceiver to the trivial-devices binding. This change is intended to
resolve dtbs_check warnings on the legacy i.MX53 SMD platform where the
device was used.

> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index 23fd4513933a4..28b059c858dd1 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -127,6 +127,8 @@ properties:
>            - domintech,dmard09
>              # DMARD10: 3-axis Accelerometer
>            - domintech,dmard10
> +            # Freescale 2.4 GHz IEEE® 802.15.4/ZigBee
> +          - fsl,mc1323

[Severity: Low]
Is it appropriate to add the Freescale MC1323 to trivial-devices.yaml?

The trivial-devices schema is strictly intended for simple I2C/SPI components
that genuinely require no hardware properties other than a compatible string,
reg, and optionally a single interrupt. 

Since the MC1323 is a complex IEEE 802.15.4 MAC/PHY SoC, does using
trivial-devices.yaml as a workaround for sparse legacy device tree nodes
create a regression in binding purity? 

Would it be better to create a dedicated minimal schema in
Documentation/devicetree/bindings/net/ieee802154/ instead, even if it
initially only lists the minimal properties needed to validate the legacy
i.MX53 SMD device tree?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260522203810.832631-1-Frank.Li@oss.nxp.com?part=1