* [PATCH v3 1/1] dt-bindings: trivial-devices: add fsl,mc1323
@ 2026-05-22 20:38 Frank.Li
2026-05-22 20:48 ` sashiko-bot
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Frank.Li @ 2026-05-22 20:38 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Guenter Roeck,
Frank Li, Wensheng Wang, Brian Chiang, Cosmo Chou, Dixit Parmar,
Eddie James, Antoni Pokusinski, Nuno Sá,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Cc: imx
From: Frank Li <Frank.Li@nxp.com>
Add freescale 2.4 GHz IEEE® 802.15.4/ZigBee mc1323 to fix the below
CHECK_DTBS warnings.
arch/arm/boot/dts/nxp/imx/imx53-smd.dtb: /soc/bus@50000000/spba-bus@50000000/spi@50010000/mc1323@0: failed to match any schema with compatible: ['fsl,mc1323']
Since the i.MX53 platform is more than 20 years old, it is difficult to
find detailed information about how the MC1323 was used on the i.MX53 SMD
board, as the functionality depended on firmware.
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
chagne in v3
- fix warning message
change in v2
- add descript about reason in commit message
---
Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
index 46a4dca50c485..6ff96e10d0785 100644
--- a/Documentation/devicetree/bindings/trivial-devices.yaml
+++ b/Documentation/devicetree/bindings/trivial-devices.yaml
@@ -127,6 +127,8 @@ properties:
- domintech,dmard09
# DMARD10: 3-axis Accelerometer
- domintech,dmard10
+ # Freescale 2.4 GHz IEEE® 802.15.4/ZigBee
+ - fsl,mc1323
# MMA7660FC: 3-Axis Orientation/Motion Detection Sensor
- fsl,mma7660
# MMA8450Q: Xtrinsic Low-power, 3-axis Xtrinsic Accelerometer
--
2.43.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v3 1/1] dt-bindings: trivial-devices: add fsl,mc1323
2026-05-22 20:38 [PATCH v3 1/1] dt-bindings: trivial-devices: add fsl,mc1323 Frank.Li
@ 2026-05-22 20:48 ` sashiko-bot
2026-05-27 9:04 ` Krzysztof Kozlowski
2026-06-01 2:19 ` Rob Herring (Arm)
2 siblings, 0 replies; 4+ messages in thread
From: sashiko-bot @ 2026-05-22 20:48 UTC (permalink / raw)
To: Frank.Li; +Cc: imx, robh, devicetree, Frank.Li, conor+dt
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The complex 802.15.4/ZigBee transceiver (Freescale MC1323) is being incorrectly added to trivial-devices.yaml.
--
commit b0a89da340a37ac000b2095bf76877af3c762c6f
Author: Frank Li <Frank.Li@nxp.com>
dt-bindings: trivial-devices: add fsl,mc1323
This commit adds the Freescale MC1323 2.4 GHz IEEE 802.15.4/ZigBee
transceiver to the trivial-devices binding. This change is intended to
resolve dtbs_check warnings on the legacy i.MX53 SMD platform where the
device was used.
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index 23fd4513933a4..28b059c858dd1 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -127,6 +127,8 @@ properties:
> - domintech,dmard09
> # DMARD10: 3-axis Accelerometer
> - domintech,dmard10
> + # Freescale 2.4 GHz IEEE® 802.15.4/ZigBee
> + - fsl,mc1323
[Severity: Low]
Is it appropriate to add the Freescale MC1323 to trivial-devices.yaml?
The trivial-devices schema is strictly intended for simple I2C/SPI components
that genuinely require no hardware properties other than a compatible string,
reg, and optionally a single interrupt.
Since the MC1323 is a complex IEEE 802.15.4 MAC/PHY SoC, does using
trivial-devices.yaml as a workaround for sparse legacy device tree nodes
create a regression in binding purity?
Would it be better to create a dedicated minimal schema in
Documentation/devicetree/bindings/net/ieee802154/ instead, even if it
initially only lists the minimal properties needed to validate the legacy
i.MX53 SMD device tree?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260522203810.832631-1-Frank.Li@oss.nxp.com?part=1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3 1/1] dt-bindings: trivial-devices: add fsl,mc1323
2026-05-22 20:38 [PATCH v3 1/1] dt-bindings: trivial-devices: add fsl,mc1323 Frank.Li
2026-05-22 20:48 ` sashiko-bot
@ 2026-05-27 9:04 ` Krzysztof Kozlowski
2026-06-01 2:19 ` Rob Herring (Arm)
2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2026-05-27 9:04 UTC (permalink / raw)
To: Frank.Li
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Guenter Roeck,
Frank Li, Wensheng Wang, Brian Chiang, Cosmo Chou, Dixit Parmar,
Eddie James, Antoni Pokusinski, Nuno Sá,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list, imx
On Fri, May 22, 2026 at 04:38:08PM -0400, Frank.Li@oss.nxp.com wrote:
> From: Frank Li <Frank.Li@nxp.com>
>
> Add freescale 2.4 GHz IEEE® 802.15.4/ZigBee mc1323 to fix the below
> CHECK_DTBS warnings.
> arch/arm/boot/dts/nxp/imx/imx53-smd.dtb: /soc/bus@50000000/spba-bus@50000000/spi@50010000/mc1323@0: failed to match any schema with compatible: ['fsl,mc1323']
>
> Since the i.MX53 platform is more than 20 years old, it is difficult to
> find detailed information about how the MC1323 was used on the i.MX53 SMD
> board, as the functionality depended on firmware.
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> chagne in v3
> - fix warning message
> change in v2
> - add descript about reason in commit message
> ---
> Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
> 1 file changed, 2 insertions(+)
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3 1/1] dt-bindings: trivial-devices: add fsl,mc1323
2026-05-22 20:38 [PATCH v3 1/1] dt-bindings: trivial-devices: add fsl,mc1323 Frank.Li
2026-05-22 20:48 ` sashiko-bot
2026-05-27 9:04 ` Krzysztof Kozlowski
@ 2026-06-01 2:19 ` Rob Herring (Arm)
2 siblings, 0 replies; 4+ messages in thread
From: Rob Herring (Arm) @ 2026-06-01 2:19 UTC (permalink / raw)
To: Frank.Li
Cc: Brian Chiang, Guenter Roeck, Krzysztof Kozlowski, Cosmo Chou,
Nuno Sá, imx, Dixit Parmar, linux-kernel, Wensheng Wang,
Conor Dooley, Frank Li, Eddie James, Antoni Pokusinski,
devicetree
On Fri, 22 May 2026 16:38:08 -0400, Frank.Li@oss.nxp.com wrote:
> From: Frank Li <Frank.Li@nxp.com>
>
> Add freescale 2.4 GHz IEEE® 802.15.4/ZigBee mc1323 to fix the below
> CHECK_DTBS warnings.
> arch/arm/boot/dts/nxp/imx/imx53-smd.dtb: /soc/bus@50000000/spba-bus@50000000/spi@50010000/mc1323@0: failed to match any schema with compatible: ['fsl,mc1323']
>
> Since the i.MX53 platform is more than 20 years old, it is difficult to
> find detailed information about how the MC1323 was used on the i.MX53 SMD
> board, as the functionality depended on firmware.
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> chagne in v3
> - fix warning message
> change in v2
> - add descript about reason in commit message
> ---
> Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-06-01 2:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-22 20:38 [PATCH v3 1/1] dt-bindings: trivial-devices: add fsl,mc1323 Frank.Li
2026-05-22 20:48 ` sashiko-bot
2026-05-27 9:04 ` Krzysztof Kozlowski
2026-06-01 2:19 ` Rob Herring (Arm)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox