Re: [PATCH] dt-bindings: mmc: mellanox,bluefield-dw-mshc: Convert DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Mismatch between node unit-address and `reg` property base address in the YAML example.
--

commit cdc4e472d6093984a0a6b661575b015b013ec9d6
Author: Manish Baing <manishbaing2789@gmail.com>

dt-bindings: mmc: mellanox,bluefield-dw-mshc: Convert DT schema

This commit converts the Mellanox BlueField SoC extensions for the Synopsys
Designware Mobile Storage Host Controller from text format to YAML schema.

> diff --git a/Documentation/devicetree/bindings/mmc/mellanox,bluefield-dw-mshc.yaml b/Documentation/devicetree/bindings/mmc/mellanox,bluefield-dw-mshc.yaml
> new file mode 100644
> index 0000000000000..32d50e45ddb86
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mmc/mellanox,bluefield-dw-mshc.yaml

[ ... ]

> +examples:
> +  - |
> +    /* Mellanox BlueField SoC MMC */
> +    mmc@2804000 {
> +        compatible = "mellanox,bluefield-dw-mshc";
> +        reg = <0x6008000 0x400>;

[Severity: Low]
Should the node unit-address match the first address in the reg property
here?

The converted YAML example uses mmc@2804000 as the node name, but retains
reg = <0x6008000 0x400>. This mismatch typically causes a unit_address_vs_reg
warning during dt_binding_check validation.

> +        interrupts = <32>;
> +        fifo-depth = <0x100>;
> +        clock-frequency = <24000000>;
> +        bus-width = <8>;
> +        cap-mmc-highspeed;
> +    };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260524094616.106660-1-manishbaing2789@gmail.com?part=1