[PATCH] dt-bindings: mmc: mellanox,bluefield-dw-mshc: Convert DT schema

[PATCH] dt-bindings: mmc: mellanox,bluefield-dw-mshc: Convert DT schema

[Manish Baing]

Convert the Mellanox BlueField SoC extensions for the Synopsys
Designware Mobile Storage Host Controller from text format
to YAML schema.

Signed-off-by: Manish Baing <manishbaing2789@gmail.com>
---
 .../bindings/mmc/bluefield-dw-mshc.txt        | 29 -----------
 .../mmc/mellanox,bluefield-dw-mshc.yaml       | 49 +++++++++++++++++++
 2 files changed, 49 insertions(+), 29 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/mmc/bluefield-dw-mshc.txt
 create mode 100644 Documentation/devicetree/bindings/mmc/mellanox,bluefield-dw-mshc.yaml

diff --git a/Documentation/devicetree/bindings/mmc/bluefield-dw-mshc.txt b/Documentation/devicetree/bindings/mmc/bluefield-dw-mshc.txt
deleted file mode 100644
index b0f0999ea1a9..000000000000
--- a/Documentation/devicetree/bindings/mmc/bluefield-dw-mshc.txt
+++ /dev/null
@@ -1,29 +0,0 @@
-* Mellanox Bluefield SoC specific extensions to the Synopsys Designware
-  Mobile Storage Host Controller
-
-Read synopsys-dw-mshc.txt for more details
-
-The Synopsys designware mobile storage host controller is used to interface
-a SoC with storage medium such as eMMC or SD/MMC cards. This file documents
-differences between the core Synopsys dw mshc controller properties described
-by synopsys-dw-mshc.txt and the properties used by the Mellanox Bluefield SoC
-specific extensions to the Synopsys Designware Mobile Storage Host Controller.
-
-Required Properties:
-
-* compatible: should be one of the following.
-  - "mellanox,bluefield-dw-mshc": for controllers with Mellanox Bluefield SoC
-    specific extensions.
-
-Example:
-
-	/* Mellanox Bluefield SoC MMC */
-	mmc@6008000 {
-		compatible = "mellanox,bluefield-dw-mshc";
-		reg = <0x6008000 0x400>;
-		interrupts = <32>;
-		fifo-depth = <0x100>;
-		clock-frequency = <24000000>;
-		bus-width = <8>;
-		cap-mmc-highspeed;
-	};
diff --git a/Documentation/devicetree/bindings/mmc/mellanox,bluefield-dw-mshc.yaml b/Documentation/devicetree/bindings/mmc/mellanox,bluefield-dw-mshc.yaml
new file mode 100644
index 000000000000..32d50e45ddb8
--- /dev/null
+++ b/Documentation/devicetree/bindings/mmc/mellanox,bluefield-dw-mshc.yaml
@@ -0,0 +1,49 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mmc/mellanox,bluefield-dw-mshc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Mellanox BlueField SoC extensions for Synopsys DesignWare MSHC
+
+maintainers:
+  - Khalil Blaiech <kblaiech@nvidia.com>
+
+description:
+  The Synopsys Designware Mobile Storage Host Controller (MSHC) on Mellanox
+  BlueField SoCs is used to interface with storage media such as eMMC or
+  SD/MMC cards. This binding documents the BlueField-specific extensions
+  and the differences from the core Synopsys DW MSHC schema.
+
+allOf:
+  - $ref: synopsys-dw-mshc-common.yaml#
+
+properties:
+  compatible:
+    const: mellanox,bluefield-dw-mshc
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+required:
+  - compatible
+  - reg
+  - interrupts
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    /* Mellanox BlueField SoC MMC */
+    mmc@2804000 {
+        compatible = "mellanox,bluefield-dw-mshc";
+        reg = <0x6008000 0x400>;
+        interrupts = <32>;
+        fifo-depth = <0x100>;
+        clock-frequency = <24000000>;
+        bus-width = <8>;
+        cap-mmc-highspeed;
+    };
-- 
2.43.0

Re: [PATCH] dt-bindings: mmc: mellanox,bluefield-dw-mshc: Convert DT schema

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Mismatch between node unit-address and `reg` property base address in the YAML example.
--

commit cdc4e472d6093984a0a6b661575b015b013ec9d6
Author: Manish Baing <manishbaing2789@gmail.com>

dt-bindings: mmc: mellanox,bluefield-dw-mshc: Convert DT schema

This commit converts the Mellanox BlueField SoC extensions for the Synopsys
Designware Mobile Storage Host Controller from text format to YAML schema.

> diff --git a/Documentation/devicetree/bindings/mmc/mellanox,bluefield-dw-mshc.yaml b/Documentation/devicetree/bindings/mmc/mellanox,bluefield-dw-mshc.yaml
> new file mode 100644
> index 0000000000000..32d50e45ddb86
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mmc/mellanox,bluefield-dw-mshc.yaml

[ ... ]

> +examples:
> +  - |
> +    /* Mellanox BlueField SoC MMC */
> +    mmc@2804000 {
> +        compatible = "mellanox,bluefield-dw-mshc";
> +        reg = <0x6008000 0x400>;

[Severity: Low]
Should the node unit-address match the first address in the reg property
here?

The converted YAML example uses mmc@2804000 as the node name, but retains
reg = <0x6008000 0x400>. This mismatch typically causes a unit_address_vs_reg
warning during dt_binding_check validation.

> +        interrupts = <32>;
> +        fifo-depth = <0x100>;
> +        clock-frequency = <24000000>;
> +        bus-width = <8>;
> +        cap-mmc-highspeed;
> +    };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260524094616.106660-1-manishbaing2789@gmail.com?part=1

Re: [PATCH] dt-bindings: mmc: mellanox,bluefield-dw-mshc: Convert DT schema

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1837 bytes --]

On Sun, May 24, 2026 at 10:15:13AM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] Mismatch between node unit-address and `reg` property base address in the YAML example.
> --
> 
> commit cdc4e472d6093984a0a6b661575b015b013ec9d6
> Author: Manish Baing <manishbaing2789@gmail.com>
> 
> dt-bindings: mmc: mellanox,bluefield-dw-mshc: Convert DT schema
> 
> This commit converts the Mellanox BlueField SoC extensions for the Synopsys
> Designware Mobile Storage Host Controller from text format to YAML schema.
> 
> > diff --git a/Documentation/devicetree/bindings/mmc/mellanox,bluefield-dw-mshc.yaml b/Documentation/devicetree/bindings/mmc/mellanox,bluefield-dw-mshc.yaml
> > new file mode 100644
> > index 0000000000000..32d50e45ddb86
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mmc/mellanox,bluefield-dw-mshc.yaml
> 
> [ ... ]
> 
> > +examples:
> > +  - |
> > +    /* Mellanox BlueField SoC MMC */
> > +    mmc@2804000 {
> > +        compatible = "mellanox,bluefield-dw-mshc";
> > +        reg = <0x6008000 0x400>;
> 
> [Severity: Low]
> Should the node unit-address match the first address in the reg property
> here?

Of course it should.
pw-bot: changes-requested

> 
> The converted YAML example uses mmc@2804000 as the node name, but retains
> reg = <0x6008000 0x400>. This mismatch typically causes a unit_address_vs_reg
> warning during dt_binding_check validation.
> 
> > +        interrupts = <32>;
> > +        fifo-depth = <0x100>;
> > +        clock-frequency = <24000000>;
> > +        bus-width = <8>;
> > +        cap-mmc-highspeed;
> > +    };
> 
> -- 
> Sashiko AI review · https://sashiko.dev/#/patchset/20260524094616.106660-1-manishbaing2789@gmail.com?part=1

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH] dt-bindings: mmc: mellanox,bluefield-dw-mshc: Convert DT schema

[Manish Baing]

Hi Conor,
Thanks for your review. I’ve already submitted a v2 that address the
unit-address mismatch based on the Shahiko bot’s feedback.
You can find the updated submission here:
https://lore.kernel.org/all/20260524111528.107251-1-manishbaing2789@gmail.com/

Thanks and Regards,
Manish


On Mon, May 25, 2026 at 10:11 PM Conor Dooley <conor@kernel.org> wrote:
>
> On Sun, May 24, 2026 at 10:15:13AM +0000, sashiko-bot@kernel.org wrote:
> > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> > - [Low] Mismatch between node unit-address and `reg` property base address in the YAML example.
> > --
> >
> > commit cdc4e472d6093984a0a6b661575b015b013ec9d6
> > Author: Manish Baing <manishbaing2789@gmail.com>
> >
> > dt-bindings: mmc: mellanox,bluefield-dw-mshc: Convert DT schema
> >
> > This commit converts the Mellanox BlueField SoC extensions for the Synopsys
> > Designware Mobile Storage Host Controller from text format to YAML schema.
> >
> > > diff --git a/Documentation/devicetree/bindings/mmc/mellanox,bluefield-dw-mshc.yaml b/Documentation/devicetree/bindings/mmc/mellanox,bluefield-dw-mshc.yaml
> > > new file mode 100644
> > > index 0000000000000..32d50e45ddb86
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/mmc/mellanox,bluefield-dw-mshc.yaml
> >
> > [ ... ]
> >
> > > +examples:
> > > +  - |
> > > +    /* Mellanox BlueField SoC MMC */
> > > +    mmc@2804000 {
> > > +        compatible = "mellanox,bluefield-dw-mshc";
> > > +        reg = <0x6008000 0x400>;
> >
> > [Severity: Low]
> > Should the node unit-address match the first address in the reg property
> > here?
>
> Of course it should.
> pw-bot: changes-requested
>
> >
> > The converted YAML example uses mmc@2804000 as the node name, but retains
> > reg = <0x6008000 0x400>. This mismatch typically causes a unit_address_vs_reg
> > warning during dt_binding_check validation.
> >
> > > +        interrupts = <32>;
> > > +        fifo-depth = <0x100>;
> > > +        clock-frequency = <24000000>;
> > > +        bus-width = <8>;
> > > +        cap-mmc-highspeed;
> > > +    };
> >
> > --
> > Sashiko AI review · https://sashiko.dev/#/patchset/20260524094616.106660-1-manishbaing2789@gmail.com?part=1