Re: [PATCH] dt-bindings: arm-smmu: qcom: Add compatible for Maili SoC

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The new compatible string `qcom,maili-smmu-500` was added to the top-level list but omitted from the `if-then` conditional blocks that enforce clock constraints, allowing invalid configurations to silently pass validation.
--

commit 2acfc9080d8935af07ba71f71f6ce29a2da3b7c0
Author: Jingyi Wang <jingyi.wang@oss.qualcomm.com>

dt-bindings: arm-smmu: qcom: Add compatible for Maili SoC
    
Qualcomm Maili SoC includes apps smmu that implements arm,mmu-500,
which is used to translate device-visible virtual addresses to
physical addresses. Add compatible for it.

> diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
> index 06fb5c8e7547c..4bd31aadc4059 100644
> --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
> @@ -38,6 +38,7 @@ properties:
>                - qcom,eliza-smmu-500
>                - qcom,glymur-smmu-500
>                - qcom,kaanapali-smmu-500
> +              - qcom,maili-smmu-500

[Severity: Medium]
Should this new compatible string also be added to the allOf conditional
blocks that enforce clock constraints?

If qcom,maili-smmu-500 is omitted from the corresponding allOf conditional
blocks, the schema falls back to the default rules which permit arbitrary
configurations (up to 7 clocks) and bypasses strict validation for this SoC.

For example, if this hardware doesn't require clocks, it would typically be
added to the block that disallows clocks:

  # Disallow clocks for all other platforms with specific compatibles
  - if:
      properties:
        compatible:
          contains:
            enum:
              ...
              - qcom,maili-smmu-500

>                - qcom,milos-smmu-500
>                - qcom,qcm2290-smmu-500
>                - qcom,qcs615-smmu-500

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260524-maili-smmu-v1-1-ec85b12fda83@oss.qualcomm.com?part=1