Devicetree
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: arm-smmu: qcom: Add compatible for Maili SoC
@ 2026-05-25  6:17 Jingyi Wang
  2026-05-25  6:35 ` sashiko-bot
  0 siblings, 1 reply; 2+ messages in thread
From: Jingyi Wang @ 2026-05-25  6:17 UTC (permalink / raw)
  To: Will Deacon, Robin Murphy, Joerg Roedel, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley
  Cc: aiqun.yu, tingwei.zhang, trilok.soni, yijie.yang,
	linux-arm-kernel, iommu, devicetree, linux-kernel, Jingyi Wang

Qualcomm Maili SoC includes apps smmu that implements arm,mmu-500,
which is used to translate device-visible virtual addresses to
physical addresses. Add compatible for it.

Signed-off-by: Jingyi Wang <jingyi.wang@oss.qualcomm.com>
---
 Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
index 06fb5c8e7547..4bd31aadc405 100644
--- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
+++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
@@ -38,6 +38,7 @@ properties:
               - qcom,eliza-smmu-500
               - qcom,glymur-smmu-500
               - qcom,kaanapali-smmu-500
+              - qcom,maili-smmu-500
               - qcom,milos-smmu-500
               - qcom,qcm2290-smmu-500
               - qcom,qcs615-smmu-500

---
base-commit: c1ecb239fa3456529a32255359fc78b69eb9d847
change-id: 20260524-maili-smmu-1004f41b3073

Best regards,
-- 
Jingyi Wang <jingyi.wang@oss.qualcomm.com>


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] dt-bindings: arm-smmu: qcom: Add compatible for Maili SoC
  2026-05-25  6:17 [PATCH] dt-bindings: arm-smmu: qcom: Add compatible for Maili SoC Jingyi Wang
@ 2026-05-25  6:35 ` sashiko-bot
  0 siblings, 0 replies; 2+ messages in thread
From: sashiko-bot @ 2026-05-25  6:35 UTC (permalink / raw)
  To: Jingyi Wang; +Cc: robh, conor+dt, devicetree

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The new compatible string `qcom,maili-smmu-500` was added to the top-level list but omitted from the `if-then` conditional blocks that enforce clock constraints, allowing invalid configurations to silently pass validation.
--

commit 2acfc9080d8935af07ba71f71f6ce29a2da3b7c0
Author: Jingyi Wang <jingyi.wang@oss.qualcomm.com>

dt-bindings: arm-smmu: qcom: Add compatible for Maili SoC
    
Qualcomm Maili SoC includes apps smmu that implements arm,mmu-500,
which is used to translate device-visible virtual addresses to
physical addresses. Add compatible for it.

> diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
> index 06fb5c8e7547c..4bd31aadc4059 100644
> --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml
> @@ -38,6 +38,7 @@ properties:
>                - qcom,eliza-smmu-500
>                - qcom,glymur-smmu-500
>                - qcom,kaanapali-smmu-500
> +              - qcom,maili-smmu-500

[Severity: Medium]
Should this new compatible string also be added to the allOf conditional
blocks that enforce clock constraints?

If qcom,maili-smmu-500 is omitted from the corresponding allOf conditional
blocks, the schema falls back to the default rules which permit arbitrary
configurations (up to 7 clocks) and bypasses strict validation for this SoC.

For example, if this hardware doesn't require clocks, it would typically be
added to the block that disallows clocks:

  # Disallow clocks for all other platforms with specific compatibles
  - if:
      properties:
        compatible:
          contains:
            enum:
              ...
              - qcom,maili-smmu-500

>                - qcom,milos-smmu-500
>                - qcom,qcm2290-smmu-500
>                - qcom,qcs615-smmu-500

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260524-maili-smmu-v1-1-ec85b12fda83@oss.qualcomm.com?part=1

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-05-25  6:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-25  6:17 [PATCH] dt-bindings: arm-smmu: qcom: Add compatible for Maili SoC Jingyi Wang
2026-05-25  6:35 ` sashiko-bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox