Re: [PATCH v5 3/7] dt-bindings: clock: qcom: Add support for CAMCC for Eliza

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Unconditionally requiring `#power-domain-cells` and `#reset-cells` for a clock controller variant that does not provide these capabilities.
--

commit 7c558a65c3468c306300eff35cc0bf8097addb20
Author: Taniya Das <taniya.das@oss.qualcomm.com>

dt-bindings: clock: qcom: Add support for CAMCC for Eliza

This commit adds the compatible strings and headers for the Eliza camera and
camera BIST clock controllers to the Milos camcc binding. It also adds
#power-domain-cells to the required properties.

> diff --git a/Documentation/devicetree/bindings/clock/qcom,milos-camcc.yaml b/Documentation/devicetree/bindings/clock/qcom,milos-camcc.yaml
> index f63149ecf3e1b..57c596314ffca 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,milos-camcc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,milos-camcc.yaml

[ ... ]

> @@ -28,6 +35,7 @@ properties:
>  required:
>    - compatible
>    - clocks
> +  - '#power-domain-cells'
>  
>  allOf:
>    - $ref: qcom,gcc.yaml#

[Severity: Medium]
Should #power-domain-cells be conditionally required instead of being applied
unconditionally to all compatibles?

Looking at the included qcom,eliza-cambistmclkcc.h header, it does not define
any power domains or resets. However, unconditionally adding
#power-domain-cells here, along with the inheritance from qcom,gcc.yaml#
(which requires #reset-cells), forces the qcom,eliza-cambistmclkcc node to
provide these properties.

Could this unconditional requirement force device tree nodes to include dummy
properties just to pass schema validation?

Would it be better to restrict these required properties to qcom,milos-camcc
and qcom,eliza-camcc using an if-then conditional block, or split the BIST
MCLK CC into a separate schema?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260525-eliza_mm_cc_v2-v5-0-a1d125619a5a@oss.qualcomm.com?part=3