Devicetree
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>
Cc: Thara Gopinath <thara.gopinath@gmail.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Vinod Koul <vkoul@kernel.org>, Frank Li <Frank.Li@kernel.org>,
	Andy Gross <agross@kernel.org>,
	linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	dmaengine@vger.kernel.org,
	Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>,
	Bartosz Golaszewski <brgl@kernel.org>,
	Gaurav Kashyap <gaurav.kashyap@oss.qualcomm.com>,
	Neeraj Soni <neeraj.soni@oss.qualcomm.com>
Subject: Re: [PATCH 0/3] Add support for qcrypto on shikra
Date: Mon, 25 May 2026 10:26:11 -0500	[thread overview]
Message-ID: <20260525152611.GD2018@quark> (raw)
In-Reply-To: <20260525142843.GA2018@quark>

On Mon, May 25, 2026 at 09:28:43AM -0500, Eric Biggers wrote:
> ARMv8 Crypto Extensions are "hardware" as well, just in the CPU.  They
> provide constant-time execution, for example.
> 
> Granted, they don't protect from power analysis and electromagnetic
> emanation attacks.  Does QCE actually provide those protections, though?
> 
> Either way, it doesn't really matter in this case.  There are multiple
> aspects to security, and before even considering these advanced
> protections, the basics of security need to be absolutely solid.  That
> is, the driver needs to always compute the crypto algorithms correctly,
> and it needs to be completely robust when fuzzed by unprivileged
> userspace (because it can accessed in that way).

Looks like these protections are not even present either.  From
https://csrc.nist.gov/CSRC/media/projects/cryptographic-module-validation-program/documents/security-policies/140sp5077.pdf :

    > The Qualcomm Crypto Engine Core does not support any non-invasive
    > security techniques. Therefore, this section is not applicable.
    [...]
    > The Qualcomm Crypto Engine Core does not implement security
    > mechanisms to mitigate other attacks.

- Eric

  reply	other threads:[~2026-05-25 15:26 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-14 19:23 [PATCH 0/3] Add support for qcrypto on shikra Kuldeep Singh
2026-05-14 19:23 ` [PATCH 1/3] dt-bindings: crypto: qcom-qce: Document the Shikra crypto engine Kuldeep Singh
2026-05-15 11:00   ` Krzysztof Kozlowski
2026-05-19  7:09     ` Kuldeep Singh
2026-05-19  7:27       ` Krzysztof Kozlowski
2026-05-19  8:55         ` Kuldeep Singh
2026-05-14 19:23 ` [PATCH 2/3] dt-bindings: bam-dma: Increase maxItems to seven for iommus Kuldeep Singh
2026-05-14 19:23 ` [PATCH 3/3] arm64: dts: qcom: shikra: Add qcrypto node support Kuldeep Singh
2026-05-15 10:28   ` Konrad Dybcio
2026-05-21  8:45     ` Kuldeep Singh
2026-05-25  8:47       ` Dmitry Baryshkov
2026-05-25 10:09         ` Kuldeep Singh
2026-05-25 10:43           ` Dmitry Baryshkov
2026-05-14 19:47 ` [PATCH 0/3] Add support for qcrypto on shikra Eric Biggers
2026-05-21  6:51   ` Kuldeep Singh
2026-05-22  2:49     ` Eric Biggers
2026-05-25  5:40       ` Kuldeep Singh
2026-05-25 14:28         ` Eric Biggers
2026-05-25 15:26           ` Eric Biggers [this message]
2026-05-25 10:07       ` Dmitry Baryshkov
2026-05-25 14:45         ` Eric Biggers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260525152611.GD2018@quark \
    --to=ebiggers@kernel.org \
    --cc=Frank.Li@kernel.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=bartosz.golaszewski@oss.qualcomm.com \
    --cc=brgl@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=gaurav.kashyap@oss.qualcomm.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=kuldeep.singh@oss.qualcomm.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neeraj.soni@oss.qualcomm.com \
    --cc=robh@kernel.org \
    --cc=thara.gopinath@gmail.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox