Re: [PATCH v3 4/5] dt-bindings: arm: qcom: Document SA8797P Ride board

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The new compatible block for the SA8797P Ride board is inserted in the incorrect section within the schema file, violating the established grouping order.
--

commit 83cce79db9a6915b8b40184fb1c89f108d45ab9f
Author: Shawn Guo <shengchao.guo@oss.qualcomm.com>

dt-bindings: arm: qcom: Document SA8797P Ride board

This commit documents the Qualcomm SA8797P Ride board, which is an automotive
development board built on the SA8797P SoC (Nord series). It introduces a
compatible block with fallback strings for the board, SoC, and Nord base.

> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -303,6 +303,12 @@ properties:
>                - xiaomi,sagit
>            - const: qcom,msm8998
>  
> +      - items:
> +          - enum:
> +              - qcom,sa8797p-ride
> +          - const: qcom,sa8797p
> +          - const: qcom,nord
> +

[Severity: Low]
This isn't a bug, but should this new compatible block be placed in the
Automotive/SA section instead?

The compatible list in this file is generally grouped alphabetically by SoC
family (such as APQ/MSM, IPQ, MDM, SA, SM, X). This insertion places the
SA8797P board immediately after the Mobile/MSM group (qcom,msm8998) and right
before the Networking/IPQ group (8dev,jalapeno). 

Could this be moved further down to sit alongside the other automotive SA
series SoCs, like qcom,sa8155p and qcom,sa8775p, to maintain the existing
file structure?

>        - items:
>            - enum:
>                - 8dev,jalapeno

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260526034557.1669007-1-shengchao.guo@oss.qualcomm.com?part=4